Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add orda/cc CLI #1041

Merged
merged 3 commits into from
Aug 9, 2023
Merged

feat: add orda/cc CLI #1041

merged 3 commits into from
Aug 9, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Jul 15, 2023

Description

closes: #XXXX

We will Implement orda CLI integration test after integrating rollup module with orda module in another PR. This PR focus on only CLI implementations.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (for-ramus@7bb78f0). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             for-ramus    #1041   +/-   ##
============================================
  Coverage             ?   62.00%           
============================================
  Files                ?      676           
  Lines                ?    79923           
  Branches             ?        0           
============================================
  Hits                 ?    49556           
  Misses               ?    27650           
  Partials             ?     2717           

@tkxkd0159 tkxkd0159 self-assigned this Aug 7, 2023
@tkxkd0159 tkxkd0159 marked this pull request as ready for review August 7, 2023 14:11
@ulbqb
Copy link
Member

ulbqb commented Aug 8, 2023

I want simapp implementing da and demo script. Are these done in another PR?

@tkxkd0159
Copy link
Member Author

tkxkd0159 commented Aug 8, 2023

I want simapp implementing da and demo script. Are these done in another PR?

Yes, they(Simapp + CLI integration test) will be covered in another PR after the rollup mdoule is done

@tkxkd0159 tkxkd0159 merged commit fa85f8a into Finschia:for-ramus Aug 9, 2023
29 checks passed
@tkxkd0159 tkxkd0159 deleted the cli-dacc branch August 9, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants