Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check store == nil #105

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix: check store == nil #105

merged 1 commit into from
Mar 23, 2021

Conversation

jinsan-line
Copy link
Contributor

Description

looks like a kind of bug. I think we need to check store == nil by the error description.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jinsan-line jinsan-line added this to the Initail ebony milestone Mar 23, 2021
@jinsan-line jinsan-line self-assigned this Mar 23, 2021
@jinsan-line jinsan-line requested a review from iproudhon March 23, 2021 09:37
wetcod
wetcod approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinsan-line jinsan-line merged commit d8e7cfb into Finschia:v2/develop Mar 23, 2021
@jinsan-line jinsan-line deleted the ebony branch March 23, 2021 09:59
@0Tech 0Tech mentioned this pull request Dec 22, 2023
Open
96 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetcod wetcod wetcod approved these changes

@egonspace egonspace egonspace approved these changes

@kukugi kukugi kukugi approved these changes

@iproudhon iproudhon Awaiting requested review from iproudhon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Initail ebony
Development

Successfully merging this pull request may close these issues.
4 participants
@jinsan-line @kukugi @egonspace @wetcod