Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump up Ostracon to 1.1.1 #1057

Merged
merged 4 commits into from
Aug 1, 2023
Merged

chore: Bump up Ostracon to 1.1.1 #1057

merged 4 commits into from
Aug 1, 2023

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Jul 31, 2023

Description

Bump up Ostracon to v1.1.1
See:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tnasu tnasu self-assigned this Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1057 (24d4a5b) into main (6613064) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   62.02%   62.02%   -0.01%     
==========================================
  Files         656      656              
  Lines       78937    78937              
==========================================
- Hits        48962    48961       -1     
- Misses      27286    27287       +1     
  Partials     2689     2689              

see 1 file with indirect coverage changes

@tnasu tnasu marked this pull request as ready for review July 31, 2023 08:38
@tnasu tnasu requested a review from zemyblue July 31, 2023 08:38
@zemyblue zemyblue added this to the v0.48.0 milestone Jul 31, 2023
@ulbqb
Copy link
Member

ulbqb commented Jul 31, 2023

Aren't there modified stub files?

@tnasu
Copy link
Member Author

tnasu commented Jul 31, 2023

@ulbqb Thanks, but, what are stub files?

@ulbqb
Copy link
Member

ulbqb commented Jul 31, 2023

@tnasu
Stub files are *.pb.go files. Are there any changes in these files?

@zemyblue
Copy link
Member

zemyblue commented Aug 1, 2023

@tnasu
Stub files are *.pb.go files. Are there any changes in these files?

The stub files of third_party is not used in fisnchia-sdk. The files in the third_party are just referred for compile.

@zemyblue zemyblue closed this Aug 1, 2023
@zemyblue zemyblue reopened this Aug 1, 2023
@zemyblue
Copy link
Member

zemyblue commented Aug 1, 2023

Sorry, closed by mistake.

@tnasu tnasu merged commit 2d437b0 into Finschia:main Aug 1, 2023
@tnasu tnasu deleted the main-tag branch August 18, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants