-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add detailed explanation about default events #1083
Merged
zemyblue
merged 3 commits into
Finschia:release/v0.47.x
from
ryu1-sakai:docs-default-event-details
Sep 20, 2023
Merged
docs: add detailed explanation about default events #1083
zemyblue
merged 3 commits into
Finschia:release/v0.47.x
from
ryu1-sakai:docs-default-event-details
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryu1-sakai
force-pushed
the
docs-default-event-details
branch
from
August 22, 2023 12:19
cb038a1
to
ca5f978
Compare
zemyblue
reviewed
Sep 6, 2023
0Tech
reviewed
Sep 6, 2023
@zemyblue, PTAL |
zemyblue
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryu1-sakai , please resolve conflicts
ryu1-sakai
force-pushed
the
docs-default-event-details
branch
from
September 13, 2023 14:24
fdcebab
to
2cdfa90
Compare
@zemyblue Rebased. |
zemyblue
approved these changes
Sep 14, 2023
tkxkd0159
approved these changes
Sep 19, 2023
zemyblue
pushed a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Oct 17, 2023
* docs: add detailed explanation about default events * Update CHANGELOG.md * improve redundant sentences (cherry picked from commit 8ae897c) # Conflicts: # CHANGELOG.md
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems better to add more detailed information about default events emitted by baseapp. (Especially information about the event structure.)
This PR is trying to add such information to the document created by #1081.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml