Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tendermint query apis for compatibility with cosmos-sdk #1087

Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Aug 18, 2023

Description

closes: #1084

Add disabled tendermint query apis of proto/cosmos/base/tendermint/v1beta1/query.proto.

Changes

  • move the converted files of proto/lbm/base/ostracon/v1/query.proto from ./client/grpc/tmservice to ./client/grpc/osservice
  • proto/cosmos/base/tendermint/v1beta1/query.proto is converted to ./client/grpc/tmservice
  • lbm query apis response original full block data, and cosmos query apis response compatible tendermint block.
  • support all query apis both lbm query api and cosmos api.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Aug 18, 2023
@zemyblue zemyblue added this to the v0.48.0 milestone Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1087 (ca8997c) into rc/v0.48.0-rcx (6bf0b53) will increase coverage by 7.53%.
The diff coverage is 73.39%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           rc/v0.48.0-rcx    #1087      +/-   ##
==================================================
+ Coverage           62.02%   69.56%   +7.53%     
==================================================
  Files                 656      642      -14     
  Lines               78941    67328   -11613     
==================================================
- Hits                48966    46837    -2129     
+ Misses              27286    18314    -8972     
+ Partials             2689     2177     -512     
Files Changed Coverage Δ
simapp/app.go 81.56% <0.00%> (-0.42%) ⬇️
client/grpc/ocservice/service.go 70.45% <70.45%> (ø)
client/grpc/tmservice/block.go 63.63% <100.00%> (ø)
client/grpc/tmservice/service.go 68.70% <100.00%> (-0.05%) ⬇️
client/grpc/tmservice/status.go 50.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

@zemyblue zemyblue marked this pull request as ready for review August 21, 2023 10:21
@zemyblue zemyblue linked an issue Aug 21, 2023 that may be closed by this pull request
4 tasks
@zemyblue zemyblue merged commit 4e315d6 into Finschia:rc/v0.48.0-rcx Aug 22, 2023
38 checks passed
@zemyblue zemyblue deleted the feat/compatibility_with_cosmos_2 branch August 22, 2023 06:59
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Aug 22, 2023
* rc/v0.48.0-rcx:
  feat: add tendermint query apis for compatibility with cosmos-sdk (Finschia#1087)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support compatibility with the Cosmos Query APIs
3 participants