-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support x/collection migration on old chains #1106
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.48.0-rcx #1106 +/- ##
==================================================
+ Coverage 69.75% 69.76% +0.01%
==================================================
Files 645 645
Lines 67468 67469 +1
==================================================
+ Hits 47060 47068 +8
+ Misses 18220 18213 -7
Partials 2188 2188
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add any unittest for this change?
Instead of adding a unit test, I've added a comment explaining the reason of the change. |
Description
This patch would support old chains in which the default class ids start from 0.
related: #1105
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml