Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(token): add additional testcase(mint, burn, modify) #1130

Merged
merged 8 commits into from
Sep 27, 2023
Merged

test(token): add additional testcase(mint, burn, modify) #1130

merged 8 commits into from
Sep 27, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Sep 22, 2023 •
edited
Loading

Description

  • Add testcases for mint, burn, modify

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #1130 (650081a) into rc/v0.48.0-rcx (6f75458) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 650081a differs from pull request most recent head 7b68e5e. Consider uploading reports for the commit 7b68e5e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1130   +/-   ##
===============================================
  Coverage           69.77%   69.77%           
===============================================
  Files                 645      645           
  Lines               67482    67482           
===============================================
+ Hits                47083    47084    +1     
+ Misses              18212    18211    -1     
  Partials             2187     2187

see 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae marked this pull request as ready for review September 22, 2023 11:00
@jaeseung-bae jaeseung-bae self-assigned this Sep 22, 2023
zemyblue
zemyblue reviewed Sep 25, 2023
View reviewed changes
x/token/keeper/msg_server_test.go Outdated Show resolved Hide resolved
x/token/keeper/keeper_test.go Outdated Show resolved Hide resolved
@zemyblue
Copy link
Member

The ci error of https://github.com/Finschia/finschia-sdk/actions/runs/6295181635/job/17088105364?pr=1130 will be fixed if #1129 is merged.

zemyblue
zemyblue previously approved these changes Sep 25, 2023
View reviewed changes
tkxkd0159
tkxkd0159 reviewed Sep 26, 2023
View reviewed changes
x/token/keeper/msg_server_test.go Outdated Show resolved Hide resolved
x/token/keeper/msg_server_test.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 changed the title chore(token): add additional testcase(mint, burn, modify) test(token): add additional testcase(mint, burn, modify) Sep 27, 2023
@jaeseung-bae jaeseung-bae merged commit e625d3d into Finschia:rc/v0.48.0-rcx Sep 27, 2023
31 checks passed
@jaeseung-bae jaeseung-bae deleted the test/token branch September 27, 2023 02:02
@zemyblue zemyblue mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@jaeseung-bae jaeseung-bae

Labels
C:x/token
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeseung-bae @zemyblue @tkxkd0159