Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement dispatch msg #1247

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

shiki-tak
Copy link
Contributor

@shiki-tak shiki-tak commented Feb 21, 2024

Description

related: #1229

DispatchMsg processes msg whose zk signature is successfully verified.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat/zkauth@9acaddc). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             feat/zkauth    #1247   +/-   ##
==============================================
  Coverage               ?   69.73%           
==============================================
  Files                  ?      654           
  Lines                  ?    67827           
  Branches               ?        0           
==============================================
  Hits                   ?    47298           
  Misses                 ?    18316           
  Partials               ?     2213           
Files Coverage Δ
x/zkauth/testutil/keeper.go 100.00% <100.00%> (ø)
x/zkauth/keeper/msg_server.go 57.14% <45.45%> (ø)
x/zkauth/keeper/keeper.go 60.19% <62.50%> (ø)
x/zkauth/types/msgs.go 0.00% <0.00%> (ø)

@shiki-tak shiki-tak self-assigned this Feb 22, 2024
@shiki-tak shiki-tak marked this pull request as ready for review February 22, 2024 00:22
@shiki-tak shiki-tak requested review from Kynea0b and Mdaiki0730 and removed request for 0Tech, tkxkd0159 and jaeseung-bae February 22, 2024 00:22
Copy link
Member

@Mdaiki0730 Mdaiki0730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiki-tak shiki-tak merged commit 6929a1d into Finschia:feat/zkauth Feb 27, 2024
32 checks passed
@zemyblue zemyblue mentioned this pull request Feb 27, 2024
10 tasks
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Feb 27, 2024
* feat/zkauth:
  feat: implement dispatch msg (Finschia#1247)

# Conflicts:
#	x/zkauth/keeper/keeper.go
#	x/zkauth/keeper/keeper_test.go
#	x/zkauth/testutil/keeper.go
#	x/zkauth/types/msgs.go
#	x/zkauth/types/tx.pb.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants