Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject NFT coins on FT APIs #1294

Merged
merged 4 commits into from
Mar 23, 2024
Merged

fix: reject NFT coins on FT APIs #1294

merged 4 commits into from
Mar 23, 2024

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 23, 2024

Description

This patch renames validateCoins() into validateFTCoins() and update its logic to reject valid NFT coins.

Motivation and context

validateCoins() are only used on FT APIs, but does not reject NFT coins. This patch addresses the problem.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: bug Something isn't working C:x/collection labels Mar 23, 2024
@0Tech 0Tech self-assigned this Mar 23, 2024
@0Tech 0Tech added the A: State Machine Breaking Any changes that result in a different AppState given same genesisState and txList. label Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (e86b980) to head (2aacdd0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1294   +/-   ##
=======================================
  Coverage   70.42%   70.42%           
=======================================
  Files         643      643           
  Lines       54702    54702           
=======================================
  Hits        38526    38526           
  Misses      14006    14006           
  Partials     2170     2170           
Files Coverage Δ
x/collection/msgs.go 98.31% <100.00%> (ø)

@0Tech 0Tech marked this pull request as ready for review March 23, 2024 02:28
@0Tech 0Tech merged commit ca39b18 into Finschia:main Mar 23, 2024
38 checks passed
@0Tech 0Tech deleted the send-nft branch March 23, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working A: State Machine Breaking Any changes that result in a different AppState given same genesisState and txList. C:x/collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants