Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename rest apis #130

Merged
merged 5 commits into from
Apr 19, 2021
Merged

chore: rename rest apis #130

merged 5 commits into from
Apr 19, 2021

Conversation

egonspace
Copy link

@egonspace egonspace commented Apr 19, 2021

Description

This PR contains two subjects.

  • rename rest api (cosmos -> lbm)
  • fix uploading codecov result (modified file: .github/workflows/test.yml)

I first uploaded this PR because of the second issue(uploading codecov result), but I couldn't check if the result was uploaded well because there was no code difference. Therefore, code modifications were required, and simple modifications were included in this PR.

For second issue

Coverage report uploading of github action was currently failing.

{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
404
==> Uploading to Codecov
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  723k  100   171  100  723k    909  3846k --:--:-- --:--:-- --:--:-- 3847k
    {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
  • (not code) activated lbm-sdk repository of codecov/line
  • (not code) registered CODECOV_TOKEN secret on the github repository
  • added using CODECOV_TOKEN to github action

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Apr 19, 2021
@egonspace egonspace added this to the Initail ebony milestone Apr 19, 2021
@egonspace egonspace changed the title chore: fix uploading codecov result chore: rename rest apis Apr 19, 2021
@egonspace
Copy link
Author

I will merge this with the top commit named chore: rename rest apis.

@egonspace egonspace merged commit c508498 into v2/develop Apr 19, 2021
@egonspace egonspace deleted the egon/v2/enable_codecov branch May 27, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants