fix: DB_BACKEND configuration #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egonspace
reviewed
Apr 20, 2021
Makefile
Outdated
| ldflags = -X github.com/line/lbm-sdk/v2/version.Name=sim \ | ||
| -X github.com/line/lbm-sdk/v2/version.AppName=simd \ | ||
| ldflags = -X github.com/line/lbm-sdk/v2/version.Name=link \ | ||
| -X github.com/line/lbm-sdk/v2/version.AppName=lbm \ |
There was a problem hiding this comment.
The sample app of lbm-sdk name is not lbm but simd.
wetcod
approved these changes
Apr 20, 2021
kukugi
approved these changes
Apr 20, 2021
egonspace
approved these changes
Apr 20, 2021
brew0722
pushed a commit
that referenced
this pull request
Apr 26, 2021
Integrate contract migrations
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related with: https://github.com/line/lbm/pull/1307
github.com/line/lbm-sdk/v2/types.DBBackendis not properly set becauseldflagsis overwritten.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes