Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump Go from 1.20 to 1.22 (backport #1410) #1411

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 7, 2024

Description

closes: #XXXX

Motivation and context

  • Replace Go version of go.mod/Github action/Docker

How has this been tested?

  • Test Environment - Use 4 nodes for testing

    • Node 1, 2 : fnsad built by Go 1.20
    • Node 3, 4 : fnsad built by Go 1.22.4
  • Test Scenario

    1. Set up 4 validators
    2. Connect four nodes each other (4P2)
    3. Send bank tx to Node1, Node3
    4. Verify that transactions are handled correctly and the statuses are queried well in Node2 and Node4
    5. Verify if there is any consensus breaking

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1410 done by [Mergify](https://mergify.com).

* Bump Go from 1.20 to 1.22.4

* follow golangci-lint rule

* Change ghaction go version

* Change the go version of all docker files

* add go version to split-test-files

* Replace slice header because it's deprecated since go 1.21

* Add CHANGELOG

* Update subdirs go version

(cherry picked from commit 7ebd36f)

# Conflicts:
#	.github/workflows/check-generated.yml
#	.github/workflows/lint.yml
#	.github/workflows/release-sims.yml
#	.github/workflows/test.yml
#	CHANGELOG.md
#	go.sum
#	tools/error_doc/go.mod
Copy link
Contributor Author

mergify bot commented Jun 7, 2024

Cherry-pick of 7ebd36f has failed:

On branch mergify/bp/release/v0.49.x/pr-1410
Your branch is up to date with 'origin/release/v0.49.x'.

You are currently cherry-picking commit 7ebd36fc4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/proto.yml
	modified:   .github/workflows/sims.yml
	modified:   .github/workflows/sims_normal.yml
	modified:   Dockerfile
	modified:   contrib/devtools/dockerfile
	modified:   contrib/images/simd-dlv/Dockerfile
	modified:   contrib/images/simd-env/Dockerfile
	modified:   contrib/rosetta/node/Dockerfile
	modified:   contrib/rosetta/rosetta-cli/Dockerfile
	modified:   go.mod
	modified:   ics23/go/go.mod
	modified:   internal/conv/string.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/check-generated.yml
	both modified:   .github/workflows/lint.yml
	both modified:   .github/workflows/release-sims.yml
	both modified:   .github/workflows/test.yml
	both modified:   CHANGELOG.md
	both modified:   go.sum
	deleted by us:   tools/error_doc/go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@tkxkd0159 tkxkd0159 self-assigned this Jun 7, 2024
* Bump Go from 1.20 to 1.22.4

* follow golangci-lint rule

* Change ghaction go version

* Change the go version of all docker files

* add go version to split-test-files

* Replace slice header because it's deprecated since go 1.21

* Add CHANGELOG

* Update subdirs go version
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (fa0164d) to head (d19465b).
Report is 2 commits behind head on release/v0.49.x.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1411      +/-   ##
===================================================
- Coverage            69.37%   67.90%   -1.47%     
===================================================
  Files                  675      770      +95     
  Lines                70058    77606    +7548     
===================================================
+ Hits                 48604    52701    +4097     
- Misses               19168    22229    +3061     
- Partials              2286     2676     +390     
Files Coverage Δ
baseapp/abci.go 58.05% <100.00%> (ø)
internal/conv/string.go 100.00% <100.00%> (ø)
types/uint.go 82.63% <100.00%> (ø)
x/distribution/keeper/delegation.go 67.30% <100.00%> (ø)
x/auth/client/cli/tx_multisign.go 0.00% <0.00%> (ø)
x/staking/keeper/val_state_change.go 59.09% <0.00%> (ø)

... and 95 files with indirect coverage changes

@tkxkd0159 tkxkd0159 added A: CI A: build dependencies Pull requests that update a dependency file and removed conflicts labels Jun 7, 2024
tkxkd0159
tkxkd0159 previously approved these changes Jun 7, 2024
@tkxkd0159 tkxkd0159 requested a review from 170210 June 7, 2024 08:25
170210
170210 previously approved these changes Jun 7, 2024
@170210 170210 self-requested a review June 7, 2024 08:34
@170210
Copy link
Contributor

170210 commented Jun 7, 2024

This PR hasn't been added in v0.49.0, so you may need remove the github action or add this pr first.

@tkxkd0159 tkxkd0159 dismissed stale reviews from 170210 and themself via d19465b June 7, 2024 08:39
@tkxkd0159 tkxkd0159 self-requested a review June 7, 2024 08:40
@tkxkd0159 tkxkd0159 merged commit af1a1a1 into release/v0.49.x Jun 7, 2024
34 of 35 checks passed
@tkxkd0159 tkxkd0159 deleted the mergify/bp/release/v0.49.x/pr-1410 branch June 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: build A: CI dependencies Pull requests that update a dependency file release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants