-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Improve code quality with new linters #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
- Coverage 69.74% 69.63% -0.12%
==========================================
Files 751 751
Lines 62259 62055 -204
==========================================
- Hits 43424 43210 -214
- Misses 16207 16214 +7
- Partials 2628 2631 +3
|
tkxkd0159
force-pushed
the
lint-code
branch
2 times, most recently
from
June 11, 2024 15:49
d898400
to
18a2a3b
Compare
170210
approved these changes
Jun 18, 2024
jaeseung-bae
approved these changes
Jun 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Use golangci-lint v1.59 * Bump golangci-lint ci from 1.55 to 1.59 * Add useful linters * Apply copyloopvar * Apply errchkjson, tenv * Apply `wastedassign` * Apply `errorlint` (cherry picked from commit d60e44a) # Conflicts: # .golangci.yml # CHANGELOG.md # Makefile # server/oc_cmds_test.go # server/util_test.go # x/foundation/client/testutil/tx.go
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
New linter list
- asasalint
- asciicheck
- bidichk
- bodyclose
- copyloopvar
- errchkjson
- errorlint
- tenv
- wastedassign
- fatcontext
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml