-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test after merge latest develop #147
Conversation
Codecov Report
@@ Coverage Diff @@
## v2/develop #147 +/- ##
==============================================
+ Coverage 54.99% 55.03% +0.04%
==============================================
Files 812 811 -1
Lines 51487 51443 -44
==============================================
- Hits 28317 28314 -3
+ Misses 20211 20189 -22
+ Partials 2959 2940 -19
|
The test below failed. However, it seems to have nothing to do with wasm, so it tries to rerun.
|
207c490
to
53c4996
Compare
Except for one thing(https://github.com/line/lbm-sdk/pull/147/files#r620243565), LGTM. |
d3beeff
to
e5e8919
Compare
e5e8919
to
b03538a
Compare
Failing race test has been confirmed as occurred randomly from the previous time regardless of wasm. |
@@ -390,6 +391,7 @@ func (s IntegrationTestSuite) TestBroadcastTx_GRPC() { | |||
} | |||
}) | |||
} | |||
time.Sleep(1 * time.Second) // wait for block confirm time before executing next test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it difficult to confirm block height and retry if the height is not succeeded? (And, if we can retry, I feel 1 second is a little long)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@egonspace, Would you please review this together when editing concurrent tx?
First of all, I will skip this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we try block confirmation and continue retrying, it will also take about a second. The purpose was to make the test pass simpler than complex code.
Other than this, LGTM! |
Description
closes: #131
After merging with the last latest develop, CI Test passed when rerun.
In reality, the test should fail.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes