Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add A New Message For Storing A Code and Instantiating A Contract With It #154

Merged
merged 8 commits into from
Apr 30, 2021

Conversation

loloicci
Copy link
Contributor

Description

This adds a new message MsgStoreCodeAndInstantiateContract and its handler. This is for storing a WASM code and instantiate a contract from it in one message (tx).

This is the stargate version of #122

closes: #111


  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
    (tests for CLI/REST are not included. The former will be added after adding linkwasmd for stargate, the latter will be added if we need REST.)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) (There are no docs)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md (It will be generated with script)
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

x/wasm/module_test.go Outdated Show resolved Hide resolved
x/wasm/module_test.go Show resolved Hide resolved
@loloicci loloicci force-pushed the loloicci/v2/feat/add-store-instantiate-msg branch from ffe1df0 to 06df152 Compare April 27, 2021 08:59
@loloicci
Copy link
Contributor Author

Sorry, using force push to rebase it to v2/develop.

@codecov
Copy link

codecov bot commented Apr 27, 2021

The author of this PR, loloicci, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at success@codecov.io with any questions.

Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci force-pushed the loloicci/v2/feat/add-store-instantiate-msg branch from c2b7d09 to 297e227 Compare April 30, 2021 08:37
@whylee259 whylee259 merged commit 2046378 into v2/develop Apr 30, 2021
@loloicci loloicci deleted the loloicci/v2/feat/add-store-instantiate-msg branch May 12, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a wasm msg that does both deployment and instantiation
4 participants