feat: concurrent recheckTx (#52) #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: simply implement abci.`CheckTxSync()` and abci.`CheckTxAsync()` * chore: move `accountLock` from `anteTx()` to `checkTxWithLock()` * feat: impl `abci.CheckTxAsync()` with reactor # Conflicts: # baseapp/baseapp.go * feat: impl `accountwgs` * feat: impl `accountwgs_test` * chore: revise code after cherry-pick * chore: bump-up tendermint & iavl * chore: rename func from `startCheckTxAsyncReactor()` to `checkTxAsyncReactor()` * fix: imports for lint * fix: imports for lint * chore: rename `Waits()` to `Wait()` # Conflicts: # baseapp/abci.go # baseapp/accountlock.go # baseapp/accountwgs_test.go # baseapp/baseapp.go # baseapp/baseapp_test.go # go.mod # go.sum
Codecov Report
@@ Coverage Diff @@
## v2/develop #155 +/- ##
==============================================
+ Coverage 54.99% 55.02% +0.02%
==============================================
Files 812 812
Lines 51487 51531 +44
==============================================
+ Hits 28317 28354 +37
- Misses 20211 20231 +20
+ Partials 2959 2946 -13
|
kukugi
approved these changes
Apr 29, 2021
wetcod
approved these changes
Apr 29, 2021
egonspace
approved these changes
Apr 29, 2021
5 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: line/lbm#1264
Cherry-pick: #52
Description
To optimize performance, we need to increase concurrency. After implementing concurrent checkTx(#49), I'd like to implement concurrent recheckTx.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes