Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore pb files when running codecov #177

Merged
merged 2 commits into from
May 11, 2021

Conversation

wetcod
Copy link
Contributor

@wetcod wetcod commented May 10, 2021

Description

  • ignore pb.go files when running codecov
  • ignore pb.gw.go files when running codecov

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@wetcod wetcod self-assigned this May 10, 2021
@kukugi
Copy link
Contributor

kukugi commented May 10, 2021

 - name: filter out DONTCOVER
        run: |
          excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')"
          excludelist+=" $(find ./ -type f -name '*.pb.go')"
          excludelist+=" $(find ./ -type f -name '*.pb.gw.go')"
          excludelist+=" $(find ./ -type f -path './tests/mocks/*.go')"
          for filename in ${excludelist}; do
            filename=$(echo $filename | sed 's/^./github.com\/line\/lbm/g')
            echo "Excluding ${filename} from coverage report..."
            sed -i.bak "/$(echo $filename | sed 's/\//\\\//g')/d" coverage.txt
          done

this is part of test.yml, it seems to exclude pb.go, pb.gw.go already when reporting codecov

@wetcod
Copy link
Contributor Author

wetcod commented May 11, 2021

@kukugi oh, I see. I'll close this PR

@wetcod wetcod closed this May 11, 2021
@wetcod wetcod reopened this May 11, 2021
@wetcod wetcod force-pushed the sangyeop/v2/ignore-pb-files branch from 350920c to 45360cb Compare May 11, 2021 09:02
@egonspace egonspace merged commit 9717c49 into v2/develop May 11, 2021
@egonspace egonspace deleted the sangyeop/v2/ignore-pb-files branch May 11, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants