Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Allow to add new validator in test network #193

Merged
merged 1 commit into from
May 12, 2021

Conversation

kukugi
Copy link
Contributor

@kukugi kukugi commented May 12, 2021

Description

Add new function to add a validator to test network. multi node cli test use this function when running test case of adding and promoting new node.

it placeed lbm-sdk side because it need to run without lock

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@kukugi kukugi self-assigned this May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #193 (340dcbf) into v2/develop (0ee1980) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 340dcbf differs from pull request most recent head a85cf6f. Consider uploading reports for the commit a85cf6f to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #193      +/-   ##
==============================================
- Coverage       53.10%   53.09%   -0.01%     
==============================================
  Files             688      688              
  Lines           49052    49057       +5     
==============================================
  Hits            26048    26048              
- Misses          20110    20115       +5     
  Partials         2894     2894              
Impacted Files Coverage Δ
testutil/network/network.go 84.45% <0.00%> (-1.82%) ⬇️
x/wasm/internal/keeper/keeper.go 86.14% <0.00%> (-0.38%) ⬇️
snapshots/store.go 75.40% <0.00%> (+1.09%) ⬆️

@kukugi kukugi requested review from wetcod, egonspace and iproudhon May 12, 2021 07:00
@kukugi kukugi force-pushed the kukugi/v2/test/multi_test branch from 340dcbf to a85cf6f Compare May 12, 2021 07:45
@kukugi kukugi merged commit f9fbaea into v2/develop May 12, 2021
@kukugi kukugi deleted the kukugi/v2/test/multi_test branch May 12, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants