Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rootmulti store parallel commit #218

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Conversation

iproudhon
Copy link
Contributor

feat: rootmulti store parallel commit
chore: += 1 -> ++ for lint

@egonspace egonspace requested review from egonspace and wetcod June 1, 2021 05:11
@egonspace egonspace added this to the performance improvement milestone Jun 1, 2021
@egonspace egonspace added the A: improvement Changes in existing functionality label Jun 1, 2021
Copy link

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #218 (73e78b2) into v2/develop (9c2db65) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #218      +/-   ##
==============================================
+ Coverage       53.49%   53.51%   +0.02%     
==============================================
  Files             652      652              
  Lines           47381    47389       +8     
==============================================
+ Hits            25348    25362      +14     
+ Misses          19173    19170       -3     
+ Partials         2860     2857       -3     
Impacted Files Coverage Δ
store/rootmulti/store.go 65.89% <100.00%> (+0.64%) ⬆️
x/wasm/internal/keeper/keeper.go 86.90% <0.00%> (+0.37%) ⬆️
types/address.go 68.23% <0.00%> (+1.44%) ⬆️

Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wetcod
Copy link
Contributor

wetcod commented Jun 1, 2021

Could you modify the title of this PR to feat: rootmulti store parallel commit for squash merge?

@egonspace egonspace changed the title Iproudhon/v2/develop feat: rootmulti store parallel commit Jun 1, 2021
@iproudhon iproudhon merged commit 2f5ffad into v2/develop Jun 2, 2021
@iproudhon iproudhon deleted the iproudhon/v2/develop branch June 2, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants