Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bech32 cache to get bech32 from proper cache #219

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

wetcod
Copy link
Contributor

@wetcod wetcod commented Jun 1, 2021

Description

fix bech32 cache to execute type casting if only values exists

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@wetcod wetcod self-assigned this Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #219 (8ecf862) into v2/develop (f904f13) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #219      +/-   ##
==============================================
+ Coverage       53.46%   53.50%   +0.03%     
==============================================
  Files             652      652              
  Lines           47379    47381       +2     
==============================================
+ Hits            25332    25350      +18     
+ Misses          19186    19172      -14     
+ Partials         2861     2859       -2     
Impacted Files Coverage Δ
types/address.go 66.78% <66.66%> (+6.05%) ⬆️

@wetcod wetcod changed the title fix: fix bech32 cache to execute type casting if only values exists fix: fix bech32 to get bech32 from proper cache Jun 1, 2021
@wetcod wetcod changed the title fix: fix bech32 to get bech32 from proper cache fix: fix bech32 cache to get bech32 from proper cache Jun 1, 2021
@wetcod wetcod force-pushed the fix-bech32-cache branch from 8f16ce9 to 8ecf862 Compare June 1, 2021 10:37
@wetcod wetcod requested a review from egonspace June 1, 2021 10:38
@wetcod wetcod merged commit 9c2db65 into v2/develop Jun 1, 2021
@wetcod wetcod deleted the fix-bech32-cache branch June 1, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants