Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace links to Cosmos's repository with ours #245

Merged
merged 15 commits into from
Jul 6, 2021

Conversation

loloicci
Copy link
Contributor

Description

Replace links to original codes with ours.


  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests (Not Needed)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) (Not Needed)
  • Added relevant godoc comments. (Not Needed)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@loloicci loloicci requested review from whylee259, brew0722 and shiki-tak and removed request for whylee259 June 10, 2021 05:47
@loloicci loloicci self-assigned this Jun 10, 2021
@loloicci
Copy link
Contributor Author

loloicci commented Jun 10, 2021

Test fails about gas in x/wasm/internal/keeper/keeper_test.go. This is not edited in this PR.
Sorry, this is because a parameter of Create is changed. I will fix it in the next patch.

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@3ccf391). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage        ?   53.64%           
=======================================
  Files           ?      652           
  Lines           ?    47368           
  Branches        ?        0           
=======================================
  Hits            ?    25410           
  Misses          ?    19097           
  Partials        ?     2861           

x/wasm/genesis_test.go Outdated Show resolved Hide resolved
x/wasm/genesis_test.go Outdated Show resolved Hide resolved
@loloicci loloicci requested a review from brew0722 June 21, 2021 09:55
@whylee259 whylee259 merged commit d0aa5a6 into main Jul 6, 2021
@whylee259 whylee259 deleted the loloicci/feat/replace-links branch July 6, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants