feat: Introduce sig block height for the new replay protection #265

egonspace · 2021-07-07T01:38:35Z

Description

Introduce sig block height to be added to tx body that is included to sign bytes.
And I removed account number concept.
This PR includes following features.

sig block height field in tx body
add the configuration VALID_SIG_BLOCK_PREIOD that limits how old the sig block height from current.
removed account number
linked empty tx of auth module to main app
unknown account may send tx (it can pass the signature verification of ante handler)
fix a bug that --offline flag of broadcast command does not work.

closes: #258

How to use

simd tx bank send link1u02ad8y2k6c8y94fhc38wm9t2pvzr90t8wlecp link19wgf6ymq2ur6r59st95e04e49m69z4al4fc982 1stake --chain-id sim --keyring-backend test --sig-block-height 100
// Of course, it is possible to omit --sig-block-height here. If you omit it, then the node use current block height as that value
// But you should specify sig-block-height to use --generate-only or --offline flag.

To test sending tx from unknown account

simd tx auth empty link1u02ad8y2k6c8y94fhc38wm9t2pvzr90t8wlecp --chain-id sim --keyring-backend test
// It's possible the account link1u02ad8y2k6c8y94fhc38wm9t2pvzr90t8wlecp is not on the chain at this moment.

Configuration

We can configure valid_sig_block_period of auth param by modifying genesis.json
This configuration property limits how much older the value of the sig block height can be than the current block height.
The default value is 100.

"auth": {
      "params": {
        "max_memo_characters": "256",
        "tx_sig_limit": "7",
        "tx_size_cost_per_byte": "10",
        "sig_verify_cost_ed25519": "590",
        "sig_verify_cost_secp256k1": "1000",
        "valid_sig_block_period": "100"
      },
      "accounts": []

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

…ock_height

… mode

codecov · 2021-07-07T01:48:06Z

Codecov Report

❗ No coverage uploaded for pull request base (main@d0aa5a6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage        ?   53.33%           
=======================================
  Files           ?      639           
  Lines           ?    46816           
  Branches        ?        0           
=======================================
  Hits            ?    24969           
  Misses          ?    18995           
  Partials        ?     2852

CLAassistant · 2021-07-07T06:20:58Z

All committers have signed the CLA.

x/auth/ante/fee.go

x/auth/ante/sigverify.go

x/auth/ante/basic.go

whylee259

LGTM

x/auth/ante/basic.go

* feat: sign block height-work1 * feat: implement sig block height; work-1 * feat: implement sig block height; work-2 * fix: make send command to require sequence flag when it is on offline mode * fix: unknown account may send tx * fix: lint error * fix: modify comment * fix: self review * docs: update changelog * fix: apply comment

Finschia#265)" This reverts commit c1c71f1. # Conflicts: # CHANGELOG.md # baseapp/msg_service_router_test.go # client/tx/tx.go # codec/amino_codec_test.go # docs/core/proto-docs.md # proto/lbm/auth/v1/auth.proto # server/grpc/server_test.go # simapp/genesis_account_test.go # simapp/test_helpers.go # testutil/testdata/unknonwnproto.pb.go # types/errors/errors.go # types/grpc/headers.go # types/rest/rest_test.go # types/tx/tx.pb.go # types/tx/types.go # x/auth/ante/ante.go # x/auth/ante/ante_test.go # x/auth/ante/sigverify_test.go # x/auth/ante/testutil_test.go # x/auth/client/cli/cli_test.go # x/auth/keeper/keeper.go # x/auth/legacy/legacytx/amino_signing_test.go # x/auth/signing/handler_map_test.go # x/auth/signing/verify_test.go # x/auth/simulation/decoder.go # x/auth/simulation/genesis.go # x/auth/tx/builder.go # x/auth/tx/direct_test.go # x/auth/tx/legacy_amino_json_test.go # x/auth/types/account.go # x/auth/types/account_retriever.go # x/auth/types/account_test.go # x/auth/types/auth.pb.go # x/auth/types/params.go # x/auth/vesting/types/vesting_account.go # x/auth/vesting/types/vesting_account_test.go # x/evidence/keeper/keeper_test.go # x/ibc/testing/chain.go # x/wasm/keeper/keeper_test.go # x/wasm/keeper/submsg_test.go

* Revert "feat: Introduce sig block height for the new replay protection (#265)" This reverts commit c1c71f1. # Conflicts: # CHANGELOG.md # baseapp/msg_service_router_test.go # client/tx/tx.go # codec/amino_codec_test.go # docs/core/proto-docs.md # proto/lbm/auth/v1/auth.proto # server/grpc/server_test.go # simapp/genesis_account_test.go # simapp/test_helpers.go # testutil/testdata/unknonwnproto.pb.go # types/errors/errors.go # types/grpc/headers.go # types/rest/rest_test.go # types/tx/tx.pb.go # types/tx/types.go # x/auth/ante/ante.go # x/auth/ante/ante_test.go # x/auth/ante/sigverify_test.go # x/auth/ante/testutil_test.go # x/auth/client/cli/cli_test.go # x/auth/keeper/keeper.go # x/auth/legacy/legacytx/amino_signing_test.go # x/auth/signing/handler_map_test.go # x/auth/signing/verify_test.go # x/auth/simulation/decoder.go # x/auth/simulation/genesis.go # x/auth/tx/builder.go # x/auth/tx/direct_test.go # x/auth/tx/legacy_amino_json_test.go # x/auth/types/account.go # x/auth/types/account_retriever.go # x/auth/types/account_test.go # x/auth/types/auth.pb.go # x/auth/types/params.go # x/auth/vesting/types/vesting_account.go # x/auth/vesting/types/vesting_account_test.go # x/evidence/keeper/keeper_test.go # x/ibc/testing/chain.go # x/wasm/keeper/keeper_test.go # x/wasm/keeper/submsg_test.go * Revert "feat: Introduce sig block height for the new replay protection (#265)" This reverts commit c1c71f1. # Conflicts: # CHANGELOG.md # baseapp/msg_service_router_test.go # client/tx/tx.go # codec/amino_codec_test.go # docs/core/proto-docs.md # proto/lbm/auth/v1/auth.proto # server/grpc/server_test.go # simapp/genesis_account_test.go # simapp/test_helpers.go # testutil/testdata/unknonwnproto.pb.go # types/errors/errors.go # types/grpc/headers.go # types/rest/rest_test.go # types/tx/tx.pb.go # types/tx/types.go # x/auth/ante/ante.go # x/auth/ante/ante_test.go # x/auth/ante/sigverify_test.go # x/auth/ante/testutil_test.go # x/auth/client/cli/cli_test.go # x/auth/keeper/keeper.go # x/auth/legacy/legacytx/amino_signing_test.go # x/auth/signing/handler_map_test.go # x/auth/signing/verify_test.go # x/auth/simulation/decoder.go # x/auth/simulation/genesis.go # x/auth/tx/builder.go # x/auth/tx/direct_test.go # x/auth/tx/legacy_amino_json_test.go # x/auth/types/account.go # x/auth/types/account_retriever.go # x/auth/types/account_test.go # x/auth/types/auth.pb.go # x/auth/types/params.go # x/auth/vesting/types/vesting_account.go # x/auth/vesting/types/vesting_account_test.go # x/evidence/keeper/keeper_test.go # x/ibc/testing/chain.go # x/wasm/keeper/keeper_test.go # x/wasm/keeper/submsg_test.go * fix: fix lint warning. * chore: add changelog about this pr * fix typo * chore: fix CHANGELOG.md links display error * Update x/auth/tx/direct.go fix: wrong comment. Co-authored-by: Sujong Lee <leesj9476@naver.com> Co-authored-by: Sujong Lee <leesj9476@naver.com>

egonspace added 8 commits June 21, 2021 17:42

feat: sign block height-work1

ac0e1a1

Merge branch 'main' of github.com:line/lfb-sdk into egon/feat/sign_bl…

6ceabc0

…ock_height

feat: implement sig block height; work-1

774e0ca

Merge branch 'main' of github.com:line/lfb-sdk into egon/feat/sign_bl…

c163425

…ock_height

feat: implement sig block height; work-2

55f5d6e

Merge branch 'main' of github.com:line/lfb-sdk into egon/feat/sign_bl…

32bdff1

…ock_height

fix: make send command to require sequence flag when it is on offline…

c3eb649

… mode

fix: unknown account may send tx

58d0196

egonspace self-assigned this Jul 7, 2021

egonspace added this to the CBDC functional requirements milestone Jul 7, 2021

egonspace requested review from brew0722, iproudhon and whylee259 July 7, 2021 01:41

egonspace added 2 commits July 7, 2021 10:53

fix: lint error

955824c

fix: modify comment

487a835

egonspace added the priority/major label Jul 7, 2021

fix: self review

416cb73

egonspace changed the title ~~feat: introduce sig block height for a tx body field.~~ feat: Introduce sig block height for the new replay protection Jul 7, 2021

docs: update changelog

13d2518

whylee259 reviewed Jul 13, 2021

View reviewed changes

x/auth/ante/fee.go Outdated Show resolved Hide resolved

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved

x/auth/ante/basic.go Show resolved Hide resolved

fix: apply comment

5a771bd

whylee259 approved these changes Jul 13, 2021

View reviewed changes

iproudhon approved these changes Jul 14, 2021

View reviewed changes

brew0722 reviewed Jul 14, 2021

View reviewed changes

x/auth/ante/basic.go Show resolved Hide resolved

brew0722 approved these changes Jul 14, 2021

View reviewed changes

egonspace merged commit c1c71f1 into main Jul 14, 2021

egonspace deleted the egon/feat/sign_block_height branch July 14, 2021 06:54

egonspace mentioned this pull request Jul 14, 2021

feat: apply sig block height of sdk Finschia/lfb#16

Merged

3 tasks

egonspace mentioned this pull request Jul 14, 2021

fix: send tx with unknown address with daemon command #286

Merged

9 tasks

egonspace mentioned this pull request Sep 14, 2021

Is it appropriate for sig_block_height to be included in the tx_body? #293

Closed

4 tasks

zemyblue mentioned this pull request Feb 10, 2022

Rollback new signing mechanism #433

Closed

4 tasks

zemyblue mentioned this pull request Feb 11, 2022

feat: Revert sig_block_height #434

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Introduce sig block height for the new replay protection #265

feat: Introduce sig block height for the new replay protection #265

egonspace commented Jul 7, 2021 •

edited

Loading

codecov bot commented Jul 7, 2021 •

edited

Loading

CLAassistant commented Jul 7, 2021 •

edited

Loading

whylee259 left a comment

feat: Introduce sig block height for the new replay protection #265

feat: Introduce sig block height for the new replay protection #265

Conversation

egonspace commented Jul 7, 2021 • edited Loading

Description

How to use

To test sending tx from unknown account

Configuration

codecov bot commented Jul 7, 2021 • edited Loading

Codecov Report

CLAassistant commented Jul 7, 2021 • edited Loading

whylee259 left a comment

Choose a reason for hiding this comment

egonspace commented Jul 7, 2021 •

edited

Loading

codecov bot commented Jul 7, 2021 •

edited

Loading

CLAassistant commented Jul 7, 2021 •

edited

Loading