Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update swagger for wasm #297

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

brew0722
Copy link
Contributor

Description

closes: #295


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@brew0722 brew0722 added the documentation Improvements or additions to documentation label Jul 21, 2021
@brew0722 brew0722 self-assigned this Jul 21, 2021
@brew0722 brew0722 requested a review from zemyblue July 21, 2021 06:12
@zemyblue
Copy link
Member

@brew0722 , some example address's prefix of swagger is cosmos. So I think it is good to change to our prefix. Do you know how we could change this?

@brew0722
Copy link
Contributor Author

@brew0722 , some example address's prefix of swagger is cosmos. So I think it is good to change to our prefix. Do you know how we could change this?

Probably independent of wasm, it seems to be an example recorded in swagger_legacy.yaml. swagger_legacy.yaml still has about gaia, tendermint, and cosmos throughout.

But as far as I know the REST API is deprecated(via lcd). So I will check to see if we need to continue supporting legacy REST APIs, and if necessary I will update them in a separate PR.

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit 7214594 into Finschia:main Jul 21, 2021
@brew0722 brew0722 deleted the swagger_wasm branch July 21, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants