feat: change wasm metrics method #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2021 09:43
telemetry has performance degradation issue.
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage ? 53.09%
=======================================
Files ? 643
Lines ? 67383
Branches ? 0
=======================================
Hits ? 35778
Misses ? 28659
Partials ? 2946 |
|
This looks not a refactor and looks like a changing feature. Isn't it? (this is tagged refactor in the title) |
brew0722
changed the title
right, changed |
loloicci
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #357
The metrics method for observing the wasm was the telemetry.
However, telemetry had performance degradation issues.
Change the method to use prometheus directly. In testing, this did not cause any performance degradation.
In addition to telemetry, wasm already had prometheus metrics for observing the cache of the VM internal implementation.
However, the observation method between our need and exist cache metrics is different .
Existing cache metrics are periodic observation by subscription of prometheus collector,
What we want is to happen at a point in time that run.
So add a new structure without refactoring the existing cache metrics.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes