-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate token module from line/link #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
changed the title
docs: Update CHANGELOG
feat: Migrate token module from line/link
Jan 18, 2022
This reverts commit 94f7b53.
0Tech
commented
Feb 16, 2022
|
||
func NewQueryCmdTokenBalance() *cobra.Command { | ||
cmd := &cobra.Command{ | ||
Use: "token-balance [class-id] [address]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite common :)
I will re-run the tests five times in a row to make sure that there is no test failure caused by x/token. |
zemyblue
approved these changes
Feb 17, 2022
0Tech
commented
Feb 17, 2022
dudong2
approved these changes
Feb 22, 2022
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Mar 4, 2022
* main: (94 commits) chore: release 0.45.0-rc0 docs: add removed custom encoder's info to changelog docs: update changelog fix: remove source and builder option from wasm tx store-and-instantiate command's help build: change depended wasmvm version to 0.16.3-0.9.0 fix: fix proto's comment and update swagger.yaml about proto chore: make format && make lint-fix fix: make lint-fix and fix errors feat: Migrate token module from line/link (Finschia#416) build(deps): bump github.com/line/ostracon from 1.0.2 to 1.0.3 (Finschia#418) fix: apply fix from release branch (Finschia#441) chore: make format chore: remove unused file chore: go fmt Ensure query isolation (Finschia#611) Optimize BalanceQuery Fix query handler instantiation Add decorator options Keeper tests (Finschia#590) Simplify filter method ... # Conflicts: # CHANGELOG.md # go.sum # simapp/app.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate token module from line/link.
#412
TODOs (separated PR):
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes