Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up cosmos sdk@v0.43.0 #460

Closed
wants to merge 600 commits into from
Closed

feat: bump up cosmos sdk@v0.43.0 #460

wants to merge 600 commits into from

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Mar 14, 2022

Description

Version up lbm-sdk to cosmos-sdk@v0.43.0.

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

* Add comment on x/auth hacky migration script

* QueryServer -> QueryRouter
@dudong2 dudong2 added the A: improvement Changes in existing functionality label Mar 14, 2022
@dudong2 dudong2 requested review from zemyblue and 0Tech March 14, 2022 08:34
@dudong2 dudong2 self-assigned this Mar 14, 2022
@dudong2 dudong2 changed the title Dudong2/feat/dump up cosmos sdk@v0.43.0 feat: dump up cosmos sdk@v0.43.0 Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/versionup_to_0_45_x@29e2abb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1f89292 differs from pull request most recent head 7ff3631. Consider uploading reports for the commit 7ff3631 to get more accurate results

Impacted file tree graph

@@                     Coverage Diff                     @@
##             feat/versionup_to_0_45_x     #460   +/-   ##
===========================================================
  Coverage                            ?   56.60%           
===========================================================
  Files                               ?      781           
  Lines                               ?    83428           
  Branches                            ?        0           
===========================================================
  Hits                                ?    47226           
  Misses                              ?    33124           
  Partials                            ?     3078           

@Finschia Finschia deleted a comment from CLAassistant Mar 14, 2022
@dudong2 dudong2 changed the title feat: dump up cosmos sdk@v0.43.0 feat: bump up cosmos sdk@v0.43.0 Mar 14, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.

✅ dudong2
✅ 0Tech
❌ mergify[bot]
❌ amaurym
❌ robert-zaremba
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 7 committers have signed the CLA.

✅ dudong2
❌ mergify[bot]
❌ fedekunze
❌ ryanchristo
❌ amaurym
❌ robert-zaremba
❌ cyberbono3
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -28,6 +28,7 @@ jobs:
with:
go-version: 1.15
- uses: ./.github/actions/generate-swagger
- run: git diff-index --quiet HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this? If it does not produce any clue, I will ask you later to remove this line as you did.

Suggested change
- run: git diff-index --quiet HEAD
- run: git diff-index --quiet HEAD
- name: report
run: git diff
if: ${{failure()}}

RiccardoM and others added 17 commits March 16, 2022 22:17
* Set proper default command output

* Removed duplicated cmd.SetErr(cmd.ErrOrStderr()) and cmd.SetOut(cmd.OutOrStdout())

* Moved command initialization and added CHANGELOG

* fix: groom all uses of cmd.Print*

* Ran make format
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.3.2 to v1.4.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.3.2...0e28ff8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
UnsafeStrToBytes is currently not safe for -d=checkptr=2, since when it
cast from smaller struct (string) to bigger struct ([]byte). That causes
checkptr complains as the casting straddle multiple heap objects.

To fix this, we have to get the string header first, then use its fields
to construct the slice.

New implementation performs the same speed with the old (wrong) one.

name                old time/op    new time/op    delta
UnsafeStrToBytes-8    25.7ns ± 1%    25.7ns ± 3%   ~     (p=0.931 n=10+17)

name                old alloc/op   new alloc/op   delta
UnsafeStrToBytes-8     7.00B ± 0%     7.00B ± 0%   ~     (all equal)

name                old allocs/op  new allocs/op  delta
UnsafeStrToBytes-8      0.00           0.00        ~     (all equal)

While at it, also simplify UnsafeBytesToStr implementation, since when
we can pass the slice directly to unsafe.Pointer, instead of getting the
slice header first.
* add: arbitrary signature adr draft

* fix: adr number

* change: adjust scope, address feedback

* fix: missing sentence

* change: address wording

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* change: address wording and formatting

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* change: address formatting

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* change: message name, address modal verbs changes

* change: document how MsgSignData should be used

* change: address wording

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* add: how verification works

* Update docs/architecture/adr-036-arbitrary-signature.md

* Update docs/architecture/adr-036-arbitrary-signature.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Apply suggestions from code review

* Update docs/architecture/adr-036-arbitrary-signature.md

* add: expand further discussion items

* fix: wording

* add: context references

* change: split offchain tx specific from MsgSignData

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marko <marbar3778@yahoo.com>
Bumps [github.com/confio/ics23/go](https://github.com/confio/ics23) from 0.6.3 to 0.6.6.
- [Release notes](https://github.com/confio/ics23/releases)
- [Commits](cosmos/ics23@v0.6.3...go/v0.6.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.4.0 to v1.4.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.4.0...967e2b3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add basics for permanent locked vesting account support

* remove sdk.Msg support for PermanentLockedVestingAccount

* add tests for PermanentLockedVestingAccount

* remove unecessary tests

* drop unecessary create vesting acct msgs

* Update x/auth/vesting/types/vesting_account.go

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update x/auth/vesting/types/vesting_account.go

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update x/auth/vesting/types/vesting_account.go

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update x/auth/vesting/types/vesting_account_test.go

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Review changes

* Factorize init function

* Factorize more

* Comments

* Fix build after rename

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
* add governance hooks

* fix lint

* fix lint

* CHANGELOG

* sh -> gh

* improve comments

* add test

* add more tests

* rename two of the hooks

Co-authored-by: ahmedaly113 <ahmedaly113@outlook.com>
… (#9163)

Ensure that we don't pass overflowed values into make, because
a clever attacker could see that to cause:

    (bits+7)/8

to become negative, they just have to make (bits+7) become negative
simply by >=maxint-6

but also reject unreasonably large element count like >2**32, which
while arbitrary is super duper large for a bit array.

Fixes #9162
…(#9167)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.20.0 to 0.21.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.20.0...v0.21.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Otherwise, NewDecFromStr may accept very large input, causing Dec
methods panic, e.g Dec.TruncateInt

Found by oss-fuzz: https://oss-fuzz.com/testcase-detail/6454129938530304

Fixes #9160
the getting started link is busted, how about we send folks to Starport? and fix a few minor editorial nits

Make integration test suites reusable by apps (#6711)

* WIP on refactoring new integration tests.

* godocs

* godocs

* Fix ineff assign

* Updates

* Updates

* fix test

* refactor crisis, distr testsuites

* fix import issue

* refactor x/auth

* refactor x/authz

* refactor x/evidence

* refactor x/feegrant

* refactor x/genutil

* refactor x/gov

* refactor x/mint

* refactor x/params

* refactor x/{auth_vesting, slashing, staking}

* fix lint

* fix tests & lint

* fix lint

* fix tests

* lint

* lint

* fix lint memory

* add missing `norace` build flag

* update feegrant cfg

* fix lint

Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>

build(deps): bump github.com/armon/go-metrics from 0.3.6 to 0.3.7 (#9187)

Bumps [github.com/armon/go-metrics](https://github.com/armon/go-metrics) from 0.3.6 to 0.3.7.
- [Release notes](https://github.com/armon/go-metrics/releases)
- [Commits](hashicorp/go-metrics@v0.3.6...v0.3.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Bumps [github.com/grpc-ecosystem/go-grpc-middleware](https://github.com/grpc-ecosystem/go-grpc-middleware) from 1.2.2 to 1.3.0.
- [Release notes](https://github.com/grpc-ecosystem/go-grpc-middleware/releases)
- [Changelog](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/CHANGELOG.md)
- [Commits](grpc-ecosystem/go-grpc-middleware@v1.2.2...v1.3.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove IBC ADRs

* remove ADR references from README

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* setup: reuses proto container

* push docker image

* set image name

* revert and use latest

Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
mergify bot and others added 28 commits March 16, 2022 22:32
… (#9841)

* fix!: Capability Issue on Restart, Backport to v0.43 (#9836)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

Closes: #9800

The following is a breaking fix to #9800. In the non-breaking fix, the initialization logic was moved out of `InitializeAndSeal` but the API was preserved. I've now removed `InitializeAndSeal` and replaced it with just the `Seal` function, which may be called much more cleanly in `app.go`

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 7f316ad)

* solve conflicts

Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
…ackport #9845) (#9846)

* style(capability)!: update go doc comments and remove BeginBlocker (#9845)

+ Backported go doc comment updates from cosmos/cosmos-sdk#9835
+ Removed BeginBlocker function which only wraps the `InitMemStore` -> https://github.com/cosmos/cosmos-sdk/pull/9835/files#r681987005  -- this is not a breaking change because RC3 was not yet released.
+ Updated changelog

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit bdf5aee)

* solve conflicts

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* chore: Changelog and Release Notes for 0.43.0-rc3

* Update release notes

* Better release notes

* Update CHANGELOG.md
* chore: v0.43.0 Changelog and Release Notes

* Update RELEASE_NOTES.md

* Update CHANGELOG.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Update RELEASE_NOTES.md

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
* ci: add swagger check

* ci: fix syntax errors

* docs: add CHANGELOG.md
…est"

This reverts commit 9168c00c2ee33d1fb601a3f95c3d242a8b1f45fd.
@dudong2 dudong2 closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.