feat: implement validateGasWanted()
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsan-line
commented
Jan 5, 2021
| @@ -41,6 +41,11 @@ func (sud SetUpContextDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate | |||
|
|
|||
| newCtx = SetGasMeter(simulate, ctx, gasTx.GetGas()) | |||
|
|
|||
| err = validateGasWanted(newCtx) | |||
| if err != nil { | |||
| return newCtx, sdkerrors.Wrap(sdkerrors.ErrOutOfGas, err.Error()) | |||
There was a problem hiding this comment.
Is ErrOutOfGas proper for this error? I'd like to hear your opinion.
kukugi
approved these changes
Jan 6, 2021
| @@ -41,6 +41,11 @@ func (sud SetUpContextDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate | |||
|
|
|||
| newCtx = SetGasMeter(simulate, ctx, gasTx.GetGas()) | |||
|
|
|||
| err = validateGasWanted(newCtx) | |||
| if err != nil { | |||
| return newCtx, sdkerrors.Wrap(sdkerrors.ErrOutOfGas, err.Error()) | |||
wetcod
approved these changes
Jan 6, 2021
3 tasks
wetcod
added a commit
that referenced
this pull request
Feb 5, 2021
* build: bump up tendermint to v0.33.9-0.1.0-rc2 * feat: implement `validateGasWanted()` (#48) * feat: impl `validateGasWanted()` * fix: lint error * chore: bump up tendermint * fix: tests to use `grpc` instead of `socket` * fix: revert the transport of the server to socket Co-authored-by: KIm, JinSan <jinsan@linecorp.com>
jinsan-line
added a commit
that referenced
this pull request
Apr 22, 2021
* feat: impl `validateGasWanted()` * fix: lint error * chore: bump up tendermint * fix: tests to use `grpc` instead of `socket` # Conflicts: # go.mod # go.sum # server/start.go # x/genutil/client/cli/init_test.go
9 tasks
jinsan-line
added a commit
that referenced
this pull request
Apr 22, 2021
* feat: impl `validateGasWanted()` * fix: lint error * chore: bump up tendermint * fix: tests to use `grpc` instead of `socket` # Conflicts: # go.mod # go.sum # server/start.go # x/genutil/client/cli/init_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with: https://github.com/line/link/issues/1153, tendermint/tendermint#5675, tendermint/tendermint#3546, Finschia/ostracon#158, (Finschia/ostracon#157)
Description
Validate
GasWantedduringante handler. It's need to remove tendermint mempool.postCheck().It should reconstruct the same logic with https://github.com/line/tendermint/blob/a01efd28c7257d3b056d1fcf263d39ccea3c1273/mempool/mempool.go#L126
Motivation and context
How has this been tested?
make test
Checklist: