fix: genesis auth account format #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 56.75% 56.85% +0.09%
==========================================
Files 777 777
Lines 83389 83633 +244
==========================================
+ Hits 47331 47547 +216
- Misses 33004 33007 +3
- Partials 3054 3079 +25
|
zemyblue
reviewed
May 3, 2022
| @@ -46,6 +46,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * (x/wasm) [\#453](https://github.com/line/lbm-sdk/pull/453) modify wasm grpc query api path | |||
| * (client) [\#476](https://github.com/line/lbm-sdk/pull/476) change the default value of the client output format in the config | |||
| * (server/grpc) [\#516](https://github.com/line/lbm-sdk/pull/516) restore build norace flag | |||
| * (genesis) [\#517](https://github.com/line/lbm-sdk/pull/517) fix genesis auth account format(cosmos-sdk style -> lbm-sdk style) | |||
| @@ -319,7 +319,7 @@ func TestInstantiate(t *testing.T) { | |||
|
|
|||
| gasAfter := ctx.GasMeter().GasConsumed() | |||
| if types.EnableGasVerification { | |||
| require.Equal(t, uint64(0x142fa), gasAfter-gasBefore) | |||
| require.Equal(t, uint64(0x1402a), gasAfter-gasBefore) | |||
There was a problem hiding this comment.
I think the cause is the decrease in the size of msg as pubkey is distinguished by type.
|
The unittest of vestingAccount's marchaling and unmarshaling functions were not existed. Please add it and increase the coverage. |
0Tech
approved these changes
May 11, 2022
brew0722
pushed a commit
to brew0722/lbm-sdk
that referenced
this pull request
May 11, 2022
* main: fix: genesis auth account format (Finschia#517) Remove reviewers on dependabot.yml updated ostracon to v1.0.5; `unsafe-reset-all` command has been moved to the `ostracon` sub-command. (Finschia#536) build(deps): bump docker/build-push-action from 2 to 3 (Finschia#532) build(deps): bump docker/metadata-action from 3 to 4 (Finschia#530) build(deps): bump docker/login-action from 1 to 2 (Finschia#531) build(deps): bump docker/setup-buildx-action from 1 to 2 (Finschia#529) chore(deps): bump github.com/VictoriaMetrics/fastcache from 1.9.0 to 1.10.0 (Finschia#499) build(deps): bump google.golang.org/protobuf from 1.27.1 to 1.28.0 (Finschia#474) chore(deps): bump github.com/prometheus/common from 0.32.1 to 0.34.0 (Finschia#510) chore(deps): bump github.com/coinbase/rosetta-sdk-go from 0.7.0 to 0.7.9 (Finschia#520) build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (Finschia#458) build(deps): bump github.com/confio/ics23/go from 0.6.6 to 0.7.0 (Finschia#448) build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (Finschia#465) build(deps): bump github.com/armon/go-metrics from 0.3.10 to 0.3.11 (Finschia#522) build(deps): bump github.com/magiconair/properties from 1.8.5 to 1.8.6 (Finschia#445) ci: change automerge conditions of Mergify (Finschia#523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I restored the part(MarshalX, UnmarshalX) that was removed due to a build failure while bumping up to cosmos-sdk@v0.45.1.
wrong format
{ "@type": "/lbm.auth.v1.BaseAccount", "account_number": "0", "address": "link146asaycmtydq45kxc8evntqfgepagygelel00h", "ed25519_pub_key": null, "multisig_pub_key": null, "secp256k1_pub_key": { "key": "AgT2QPS4Eu6M+cfHeba+3tumsM/hNEBGdM7nRojSZRjF" }, "secp256r1_pub_key": null, "sequence": "1" },right format
{ "@type": "/lbm.auth.v1.BaseAccount", "account_number": 0, "address": "link146asaycmtydq45kxc8evntqfgepagygelel00h", "pub_key": { "key": "eyJrZXkiOiJBZ1QyUVBTNEV1Nk0rY2ZIZWJhKzN0dW1zTS9oTkVCR2RNN25Sb2pTWlJqRiJ9", "type": 1 }, "sequence": "1" },closes: #515
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml