Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unmarshal bug of BaseAccountJSON. #563

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jun 10, 2022

Description

Fixed unmarshal error if account_number of genesis auth's account is string type when load the genesis file

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested review from 0Tech and dudong2 June 10, 2022 13:03
@zemyblue zemyblue self-assigned this Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #563 (cabf6a2) into main (ac918ac) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   57.58%   57.58%   -0.01%     
==========================================
  Files         793      793              
  Lines       86584    86584              
==========================================
- Hits        49858    49857       -1     
- Misses      33564    33565       +1     
  Partials     3162     3162              
Impacted Files Coverage Δ
x/auth/types/account.go 61.70% <ø> (ø)
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor comments.

x/auth/types/account_test.go Outdated Show resolved Hide resolved
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
@zemyblue zemyblue merged commit 996ef60 into Finschia:main Jun 14, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants