feat: remove prove field in the GetTxsEventRequest of tx proto.
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 57.68% 57.68% -0.01%
==========================================
Files 793 793
Lines 87013 87013
==========================================
- Hits 50193 50190 -3
- Misses 33662 33664 +2
- Partials 3158 3159 +1
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
dudong2
approved these changes
Jul 8, 2022
0Tech
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
provefield is added int #291. But in this PR, there is not the reason why this function is necessary, etc. I think it is to select whether to output the evidence that the corresponding tx is included in the block in the result according to the value ofprovewhen We requestGetTxsEvent.However, there is not the
provefield in the cosmos-sdk, and evidence of including block is to be added to all results by default. AndTODOis written that it needs to be fixed.The modified some codes in the #291 was reverted in the #495 which update to cosmos-sdk v0.45.1. We cannot select the result of
GetTxsEvent's prove for now, but it is not occurred any problem.I think it would be better to revert
proveselection function for compability with cosmos-sdk.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml