-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove cache from store(iavl) #595
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 814 814
Lines 94798 94783 -15
=======================================
- Hits 57448 57445 -3
+ Misses 34097 34085 -12
Partials 3253 3253
|
dudong2
force-pushed
the
dudong2/perf/remove-iavl-cache
branch
2 times, most recently
from
July 19, 2022 01:50
a62c281
to
a583ff6
Compare
dudong2
force-pushed
the
dudong2/perf/remove-iavl-cache
branch
from
July 19, 2022 08:33
a583ff6
to
f3c2dd5
Compare
Please add changelog to |
Please remove |
I added it |
I removed 'freecache' from 'go.mod' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: Evaluation of Datastore Caching changes #581
Motivation and context
Unlike cosmos-sdk, lbm-sdk uses fastcache in iavl. According to the benchmarking results, the performance was better when the cache was not used. So I decided to roll back.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml