Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove cache from store(iavl) #595

Closed
wants to merge 13 commits into from

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Jul 14, 2022

Description

Motivation and context

Unlike cosmos-sdk, lbm-sdk uses fastcache in iavl. According to the benchmarking results, the performance was better when the cache was not used. So I decided to roll back.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 requested review from zemyblue and 0Tech July 14, 2022 03:51
@dudong2 dudong2 self-assigned this Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #595 (0b68f82) into main (1bc3aac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files         814      814           
  Lines       94798    94783   -15     
=======================================
- Hits        57448    57445    -3     
+ Misses      34097    34085   -12     
  Partials     3253     3253           
Impacted Files Coverage Δ
server/mock/store.go 20.21% <ø> (-1.22%) ⬇️
store/types/store.go 56.25% <ø> (ø)
baseapp/options.go 69.91% <100.00%> (+4.07%) ⬆️
simapp/simd/cmd/root.go 80.68% <100.00%> (-0.17%) ⬇️
store/rootmulti/store.go 69.31% <100.00%> (+0.20%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@tnasu tnasu requested a review from torao July 14, 2022 06:09
@dudong2 dudong2 force-pushed the dudong2/perf/remove-iavl-cache branch 2 times, most recently from a62c281 to a583ff6 Compare July 19, 2022 01:50
@dudong2 dudong2 force-pushed the dudong2/perf/remove-iavl-cache branch from a583ff6 to f3c2dd5 Compare July 19, 2022 08:33
@zemyblue
Copy link
Member

Please add changelog to CHANGELOG.md

@zemyblue
Copy link
Member

Please remove freecache library in go.mod.

@dudong2
Copy link
Contributor Author

dudong2 commented Jul 19, 2022

Please add changelog to CHANGELOG.md

I added it

@dudong2
Copy link
Contributor Author

dudong2 commented Jul 19, 2022

Please remove freecache library in go.mod.

I removed 'freecache' from 'go.mod'

@dudong2 dudong2 closed this Jul 21, 2022
@dudong2 dudong2 deleted the dudong2/perf/remove-iavl-cache branch July 21, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation of Datastore Caching changes
2 participants