Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove new APIs on x/collection #608

Merged
merged 10 commits into from
Jul 26, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 24, 2022

Motivation and context

As this module is obsolete, we do not plan to add any more new features.
Security maintenance may continue.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #608 (9ca2089) into main (8b9e3e5) will increase coverage by 0.16%.
The diff coverage is 97.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   59.56%   59.72%   +0.16%     
==========================================
  Files         811      811              
  Lines       95263    94747     -516     
==========================================
- Hits        56744    56589     -155     
+ Misses      34974    34674     -300     
+ Partials     3545     3484      -61     
Impacted Files Coverage Δ
x/collection/codec.go 0.00% <0.00%> (ø)
x/collection/collection.go 80.35% <0.00%> (-1.13%) ⬇️
x/collection/keeper/msg_server.go 74.85% <ø> (+0.92%) ⬆️
x/collection/msgs.go 38.14% <ø> (+6.75%) ⬆️
x/collection/keeper/grpc_query.go 89.58% <80.76%> (-3.13%) ⬇️
x/collection/client/testutil/query.go 100.00% <100.00%> (ø)
x/collection/client/testutil/suite.go 99.60% <100.00%> (+<0.01%) ⬆️
x/collection/client/testutil/tx.go 100.00% <100.00%> (ø)
x/collection/keeper/keys.go 100.00% <100.00%> (ø)
x/collection/keeper/send.go 91.08% <100.00%> (ø)
... and 9 more

@0Tech 0Tech requested review from dudong2 and zemyblue July 24, 2022 08:07
@0Tech 0Tech marked this pull request as ready for review July 24, 2022 08:07
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check swagger and statik files.

@0Tech
Copy link
Collaborator Author

0Tech commented Jul 26, 2022

Please check swagger and statik files.

It has been applied into #604. This PR must wait for it.

@0Tech 0Tech merged commit 4cc8685 into Finschia:main Jul 26, 2022
@0Tech 0Tech deleted the collection_refactor branch July 26, 2022 06:39
dudong2 pushed a commit to dudong2/lbm-sdk that referenced this pull request Aug 1, 2022
* refactor: remove new tx

* refactor: remove new query

* feat: add Query/TokensWithTokenType

* fix: modify error

* docs: update variable names in the comments

* docs: update CHANGELOG.md

* Update swagger

* Remove unused rename in swagger config
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants