Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify docker build #619

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Modify docker build #619

merged 5 commits into from
Aug 2, 2022

Conversation

shiki-tak
Copy link
Contributor

Description

Change the Dockerfile to use the downloaded static library
Related: Finschia/finschia#76

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@shiki-tak shiki-tak self-assigned this Aug 2, 2022
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog in CHANGELOG.md.

Dockerfile Show resolved Hide resolved
@shiki-tak shiki-tak merged commit 3d85b26 into Finschia:main Aug 2, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants