Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/wasm refactoring - detaching the custom wasm proto part of lbm-sdk #661

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Sep 5, 2022

Description

closes: #623

Apply the changes of #625 and #655 to the main branch

  • detaching `StoreCodeAndInstantiateContract from wasm's tx.proto
  • add inactive contract management in wasm

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

zemyblue and others added 3 commits August 17, 2022 15:54
…625)

* feat: detaching StoreCodeAndInstantiateContract from wasm's tx.proto

Signed-off-by: zemyblue <zemyblue@gmail.com>

* feat: revert wasm proto to cosmwasm proto and add custom proto to `lbm/wasm/v1`.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: fix lint error.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: add wasm cli unittest

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: fix lint warning

Signed-off-by: zemyblue <zemyblue@gmail.com>

* Update x/wasm/lbm/types/tx_test.go

Co-authored-by: Sujong Lee <leesj9476lsj@gmail.com>

* chore: apply feedback

Signed-off-by: zemyblue <zemyblue@gmail.com>

* fix: lint error

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: apply review feedback

Signed-off-by: zemyblue <zemyblue@gmail.com>

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: Sujong Lee <leesj9476lsj@gmail.com>
* feat: add inactive contract management in wasm.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: add unittest in the x/wasm/lbm/keeper

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: fix lint warning

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: fix lint warning

Signed-off-by: zemyblue <zemyblue@gmail.com>

* feat: add proposal cli and unittest of lbm wasm

Signed-off-by: zemyblue <zemyblue@gmail.com>

* fix: lint warning

Signed-off-by: zemyblue <zemyblue@gmail.com>

* feat: add contract blacklist function
 - add inactive_contract_addresses in genesisStatus
 - modify Params of wasm
 - add custom tx and queries

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: add wasm genesis for `TestProposalActivateContractCmd`

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: change private `setParams` to public `SetParams` function of wasm.Keeper.
And change to proper gas data in unittest.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: change CHANGELOG

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: apply review feedback

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: apply review feedback(2)
 - response error if there isn't contract address in chain

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: apply review feedback(3)

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: apply review feedback(4)

Signed-off-by: zemyblue <zemyblue@gmail.com>

* fix: remove unsupported flags

Signed-off-by: zemyblue <zemyblue@gmail.com>

* fix: fix lint warning.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: unify the period point of the comment.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: unify comment period point

Signed-off-by: zemyblue <zemyblue@gmail.com>

Signed-off-by: zemyblue <zemyblue@gmail.com>
* main:
  fix: wasm module's FIXME in the snapshotter.go file (#649)
  chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650)
  chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648)
  fix: remove legacy codes of wasm (#640)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643)
  chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642)
  chore: change some minor things that haven't been fixed in #549 (#635)
  refactor: rename x/collection events (#639)
  feat: add additional fields into x/collection events (#638)
  refactor: rename x/token events (#637)
  feat: add creator into x/token EventIssue (#636)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641)
  chore: change `Keeper.space` type to be same with cosmos-sdk
  refactor: remove SetBalance and SetSupply (#629)
  refactor: revert changes in x/slashing proto (#627)
  chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631)
  chore(deps): Bump github.com/prometheus/client_golang (#632)
  chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624)
  feat: add Query/TokenClassTypeName (#622)
  feat: add additional information into EventXXXChanged (#621)

Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	client/docs/statik/statik.go
#	simapp/app.go
#	x/wasm/types/events.go
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #661 (2c25dba) into main (86ccc34) will increase coverage by 0.24%.
The diff coverage is 75.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   60.23%   60.48%   +0.24%     
==========================================
  Files         815      826      +11     
  Lines       94895    96128    +1233     
==========================================
+ Hits        57163    58139     +976     
- Misses      34255    34507     +252     
- Partials     3477     3482       +5     
Impacted Files Coverage Δ
simapp/test_access.go 0.00% <0.00%> (ø)
x/wasm/client/cli/genesis_msg.go 69.32% <ø> (ø)
x/wasm/client/cli/gov_tx.go 0.00% <0.00%> (ø)
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)
x/wasm/client/cli/tx.go 16.10% <0.00%> (ø)
x/wasm/keeper/authz_policy.go 100.00% <ø> (ø)
x/wasm/keeper/legacy_querier.go 57.93% <0.00%> (-8.43%) ⬇️
x/wasm/keeper/msg_server.go 18.93% <0.00%> (ø)
x/wasm/types/codec.go 100.00% <ø> (ø)
x/wasm/types/genesis.go 89.15% <0.00%> (-4.52%) ⬇️
... and 32 more

Signed-off-by: zemyblue <zemyblue@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested a review from 0Tech September 5, 2022 11:35
@zemyblue zemyblue merged commit 070ab3f into main Sep 6, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@zemyblue zemyblue deleted the feat/wasm_refactor branch October 25, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detaching the custom wasm proto part of lbm-sdk
5 participants