-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/wasm refactoring - detaching the custom wasm proto part of lbm-sdk #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…625) * feat: detaching StoreCodeAndInstantiateContract from wasm's tx.proto Signed-off-by: zemyblue <zemyblue@gmail.com> * feat: revert wasm proto to cosmwasm proto and add custom proto to `lbm/wasm/v1`. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: fix lint error. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: add wasm cli unittest Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: fix lint warning Signed-off-by: zemyblue <zemyblue@gmail.com> * Update x/wasm/lbm/types/tx_test.go Co-authored-by: Sujong Lee <leesj9476lsj@gmail.com> * chore: apply feedback Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: lint error Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: apply review feedback Signed-off-by: zemyblue <zemyblue@gmail.com> Signed-off-by: zemyblue <zemyblue@gmail.com> Co-authored-by: Sujong Lee <leesj9476lsj@gmail.com>
* feat: add inactive contract management in wasm. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: add unittest in the x/wasm/lbm/keeper Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: fix lint warning Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: fix lint warning Signed-off-by: zemyblue <zemyblue@gmail.com> * feat: add proposal cli and unittest of lbm wasm Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: lint warning Signed-off-by: zemyblue <zemyblue@gmail.com> * feat: add contract blacklist function - add inactive_contract_addresses in genesisStatus - modify Params of wasm - add custom tx and queries Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: add wasm genesis for `TestProposalActivateContractCmd` Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change private `setParams` to public `SetParams` function of wasm.Keeper. And change to proper gas data in unittest. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change CHANGELOG Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: apply review feedback Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: apply review feedback(2) - response error if there isn't contract address in chain Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: apply review feedback(3) Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: apply review feedback(4) Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: remove unsupported flags Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: fix lint warning. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: unify the period point of the comment. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: unify comment period point Signed-off-by: zemyblue <zemyblue@gmail.com> Signed-off-by: zemyblue <zemyblue@gmail.com>
* main: fix: wasm module's FIXME in the snapshotter.go file (#649) chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650) chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648) fix: remove legacy codes of wasm (#640) chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643) chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642) chore: change some minor things that haven't been fixed in #549 (#635) refactor: rename x/collection events (#639) feat: add additional fields into x/collection events (#638) refactor: rename x/token events (#637) feat: add creator into x/token EventIssue (#636) chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641) chore: change `Keeper.space` type to be same with cosmos-sdk refactor: remove SetBalance and SetSupply (#629) refactor: revert changes in x/slashing proto (#627) chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631) chore(deps): Bump github.com/prometheus/client_golang (#632) chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624) feat: add Query/TokenClassTypeName (#622) feat: add additional information into EventXXXChanged (#621) Signed-off-by: zemyblue <zemyblue@gmail.com> # Conflicts: # CHANGELOG.md # client/docs/statik/statik.go # simapp/app.go # x/wasm/types/events.go
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 60.23% 60.48% +0.24%
==========================================
Files 815 826 +11
Lines 94895 96128 +1233
==========================================
+ Hits 57163 58139 +976
- Misses 34255 34507 +252
- Partials 3477 3482 +5
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
requested changes
Sep 5, 2022
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
approved these changes
Sep 6, 2022
shiki-tak
approved these changes
Sep 6, 2022
loloicci
approved these changes
Sep 6, 2022
dudong2
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #623
Apply the changes of #625 and #655 to the main branch
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml