Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove x/foundation UpdateValidatorAuthsProposal #685

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Sep 27, 2022

Description

This patch removes UpdateValidatorAuthsProposal of x/foundation which extends x/gov proposal. As a result, granter is no more in use, because x/foundation would be the only granter.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #685 (ea86fbe) into main (fcaf1c5) will decrease coverage by 0.06%.
The diff coverage is 85.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
- Coverage   61.11%   61.04%   -0.07%     
==========================================
  Files         873      873              
  Lines       98602    98429     -173     
==========================================
- Hits        60260    60088     -172     
- Misses      34736    34742       +6     
+ Partials     3606     3599       -7     
Impacted Files Coverage Δ
simapp/app.go 86.14% <ø> (ø)
x/foundation/client/testutil/suite.go 97.90% <ø> (-0.02%) ⬇️
x/foundation/client/testutil/tx.go 99.24% <ø> (-0.09%) ⬇️
x/foundation/codec.go 0.00% <ø> (ø)
x/foundation/keeper/grpc_query.go 4.27% <0.00%> (ø)
x/foundation/keeper/handler.go 10.00% <ø> (-48.34%) ⬇️
x/foundation/keeper/proposal.go 65.49% <ø> (-4.82%) ⬇️
x/foundation/proposal.go 75.00% <ø> (+7.20%) ⬆️
x/foundation/keeper/keeper.go 83.33% <50.00%> (ø)
x/foundation/keeper/msg_server.go 74.50% <66.66%> (-1.42%) ⬇️
... and 12 more

@0Tech 0Tech marked this pull request as ready for review September 27, 2022 04:21
@0Tech 0Tech requested review from dudong2 and zemyblue September 27, 2022 04:21
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this patch is applied, the already launched chain should be reset. Is it right?

@0Tech
Copy link
Collaborator Author

0Tech commented Sep 28, 2022

If this patch is applied, the already launched chain should be reset. Is it right?

Of course, yes, because it affects the state.

@0Tech 0Tech requested a review from zemyblue September 28, 2022 08:25
@0Tech 0Tech merged commit 47eeccc into Finschia:main Sep 28, 2022
@0Tech 0Tech deleted the foundation_proposal branch September 28, 2022 12:25
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants