Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify cache sizes to be configurable #71

Merged
merged 7 commits into from
Feb 9, 2021

Conversation

wetcod
Copy link
Contributor

@wetcod wetcod commented Feb 8, 2021

Related https://github.com/line/link/issues/1181
Related https://github.com/line/link/issues/1182

Description

modify cache sizes to be configurable

  • add inter-block-cache-size to config
  • add iavl-cache-size to config

add metrics for cache size

Motivation and context

We need to modify inter block cache size and iavl node cache size to configuable.

How has this been tested?

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@wetcod wetcod self-assigned this Feb 8, 2021
Copy link
Contributor

@kukugi kukugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wetcod wetcod merged commit 88cb76c into Finschia:develop Feb 9, 2021
egonspace pushed a commit that referenced this pull request Mar 28, 2021
skip PR comment on non PR branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants