Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix x/foundation EndBlocker #712

Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix: fix x/foundation EndBlocker #712

merged 2 commits into from
Oct 17, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 13, 2022

Description

This patch will fix EndBlocker() of x/foundation and add the corresponding unit tests.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Oct 13, 2022
@0Tech 0Tech self-assigned this Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #712 (6f8569b) into main (289ca6b) will increase coverage by 0.03%.
The diff coverage is 89.58%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   61.83%   61.87%   +0.03%     
==========================================
  Files         874      874              
  Lines       98557    98577      +20     
==========================================
+ Hits        60944    60991      +47     
+ Misses      33982    33945      -37     
- Partials     3631     3641      +10     
Impacted Files Coverage Δ
x/foundation/keeper/proposal.go 78.40% <62.50%> (+13.46%) ⬆️
x/foundation/keeper/keys.go 97.95% <95.00%> (-2.05%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/token/msgs.go 32.99% <0.00%> (-1.53%) ⬇️
x/collection/msgs.go 40.18% <0.00%> (+0.18%) ⬆️
x/foundation/keeper/tally.go 69.23% <0.00%> (+11.53%) ⬆️
x/foundation/keeper/abci.go 75.00% <0.00%> (+37.50%) ⬆️

@0Tech 0Tech marked this pull request as ready for review October 14, 2022 01:03
Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech requested a review from zemyblue October 14, 2022 08:55
@0Tech 0Tech merged commit 00ab960 into Finschia:main Oct 17, 2022
@0Tech 0Tech deleted the foundation_fix branch October 17, 2022 09:47
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants