feat: add flag for the private key selection #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kynea0b
requested review from
egonspace,
jinsan-line,
wetcod,
tnasu and
torao
jinsan-line
reviewed
Feb 10, 2021
server/tm_cmds.go
Outdated
| @@ -5,6 +5,7 @@ package server | |||
| import ( | |||
| "fmt" | |||
|
|
|||
| "github.com/cosmos/cosmos-sdk/client/flags" | |||
There was a problem hiding this comment.
nit but I think we need to move this line to the below other cosmos-sdk imports.
I think it's a kind of pain point that doesn't work w/ auto formatting but we need to follow up the convention.
There was a problem hiding this comment.
Oh, that's right. I think so, too. I will correct this! Thank you!
jinsan-line
approved these changes
Feb 10, 2021
tnasu
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
LGTM
But I think we should re-examine where we are using GenFilePV.
(I mean that it wasn't enough to just use GenFilePV through LoadOrGenFilePV and ResetAll.)
- tendermint/privval/file.go:LoadOrGenFilePV
- tendermint/cmd/tendermint/commands/reset_prev_validator.go:resetFilePV
I've found the others candidates the followings:
- tendermint/cmd/tendermint/commands/gen_validator.go:genValidator
- tendermint/cmd/tendermint/commands/init.go:initFilesWithConfig
- tendermint/consensus/common_test.go:randConsensusNetWithPeers
|
Thank you. I understand. |
Kynea0b
merged commit 5c778f6
into
Finschia:v0.38.5-0.1.0-linking_link_with_line_consensus
egonspace
pushed a commit
that referenced
this pull request
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
This is an omission of correction of this PR.
#43
Motivation and context
Same as this PR #43.
How has this been tested?
Same as this PR #43.
Ref:
Finschia/ostracon#125
line/link#1111
line/link#1133
Checklist:
I have updated the documentation accordingly.I have added tests to cover my changes.