Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix max gas validation (backport #673) #746

Merged
merged 3 commits into from
Oct 25, 2022
Merged

fix: fix max gas validation (backport #673) #746

merged 3 commits into from
Oct 25, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 21, 2022

This is a manual backport of pull request #673 from rc/v0.46.0-rc8.

* Run the validation on checkTx

* Set consensus params

* Update CHANGELOG.md

* Update workflows

* Add tests to cover ReCheckTx of validateMaxGas

* Add tests to cover consensus parameter updates
@0Tech 0Tech self-assigned this Oct 21, 2022
@0Tech 0Tech requested a review from zemyblue October 21, 2022 04:30
@0Tech 0Tech changed the title fix: fix max gas validation (#673) fix: fix max gas validation (backport #673) Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #746 (cafab15) into main (1726293) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   62.06%   62.06%   -0.01%     
==========================================
  Files         877      877              
  Lines       98977    98977              
==========================================
- Hits        61432    61429       -3     
- Misses      33927    33931       +4     
+ Partials     3618     3617       -1     
Impacted Files Coverage Δ
baseapp/abci.go 62.40% <100.00%> (ø)
baseapp/baseapp.go 80.36% <100.00%> (+0.04%) ⬆️
x/auth/ante/setup.go 81.13% <100.00%> (+12.61%) ⬆️
x/token/validation.go 70.90% <0.00%> (-21.82%) ⬇️
x/token/msgs.go 35.02% <0.00%> (-5.59%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/wasm/keeper/keeper.go 86.53% <0.00%> (+0.36%) ⬆️
x/collection/msgs.go 39.81% <0.00%> (+1.48%) ⬆️
x/collection/collection.go 80.35% <0.00%> (+1.78%) ⬆️

@0Tech 0Tech requested review from dudong2, loin3 and tkxkd0159 October 21, 2022 05:44
@0Tech 0Tech marked this pull request as ready for review October 21, 2022 05:44
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@0Tech 0Tech removed the C:x/foundation x/foundation module label Oct 24, 2022
@0Tech 0Tech merged commit 84ddf95 into main Oct 25, 2022
@0Tech 0Tech deleted the rc/v0.46.0-rc8 branch October 25, 2022 02:07
@0Tech 0Tech restored the rc/v0.46.0-rc8 branch October 25, 2022 08:18
@0Tech 0Tech deleted the rc/v0.46.0-rc8 branch October 25, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants