Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: v0.39.2 0.2.0 #97

Merged
merged 7 commits into from
Mar 23, 2021
Merged

merge: v0.39.2 0.2.0 #97

merged 7 commits into from
Mar 23, 2021

Conversation

egonspace
Copy link

@egonspace egonspace commented Mar 22, 2021

Description

5ff8553: "Bump tendermint (#5)"
-> not necessary

1cdefea: "feat: add codespace to broadcast response (#6)"
-> 1cdefea

4e68457: "chore: expose usedCodes for document (#7)"
-> d4ad039

0cc0556: "fix: query error (#9)"
-> d3e8ed6

3d73f3e: "fix: check internalABCICodespace (#10)"
-> ffc1a8b

6e253d5: "fix: Send response with 404 status when quering non-exist account (#14)"
-> 4d92d7f

6d6459b: "feat: add custom query with check state (#15)"
-> It's so complicated. I'll apply it in another PR.

4f99083 test: circleci enable (#20)
-> not necessary

7836a58: "chore: disable toooooo long test (#22)"
-> not necessary

1a28da1: "Revert 'Mege PR #6749: auth: remove custom JSON marshaling'"
-> not necessary

fd6d941: "feat: bump up iavl 0.4.3 (#36)"
-> not necessary

I left some TODO tags.

  • ./.github/workflows/sims.yml:# TODO ebony: fix sim test failure
  • ./.github/workflows/test.yml:# TODO ebony: enable this test
  • ./.github/workflows/test.yml:# TODO ebony: fix module download error in docker
  • Dockerfile:# TODO ebony: fix module download error in docker

I used github.com/cosmos/cosmos-sdk urls in cosmovisor tests because it was too difficult to modify the url to github/line/lbm-sdk/v2. These tests were trying to download some binary file from that url with commit hash and zip hash code.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Yongwoo Lee and others added 5 commits March 19, 2021 09:03
* fix: check UndefinedCodespace too

* Update types/errors/abci.go

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>

Co-authored-by: Yongwoo Lee <whylee@linecorp.com>
@egonspace egonspace self-assigned this Mar 22, 2021
@egonspace egonspace added this to the Initail ebony milestone Mar 22, 2021
@egonspace egonspace force-pushed the v2/merge_v0.39.2-0.2.0 branch from 5e44c2b to bcd1aca Compare March 22, 2021 11:41
Dockerfile Outdated Show resolved Hide resolved
@egonspace egonspace requested a review from iproudhon March 23, 2021 00:13
@egonspace egonspace merged commit 19d6caf into v2/develop Mar 23, 2021
@egonspace egonspace deleted the v2/merge_v0.39.2-0.2.0 branch March 24, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants