Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix release-build ci error occurred when adding assets after tagging #163

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Apr 3, 2023

Description

When adding assets after tagging in release-build ci, ci failed because the name of build binary is different from what ci expected. The expected name for ci is lbm-xxxx, but it changed to finschia-xxx.
It is fixed.

Motivation and context

ci error:
https://github.com/line/finschia/actions/runs/4552341112/jobs/8027559348
스크린샷 2023-04-03 오후 3 00 43

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue self-assigned this Apr 3, 2023
@zemyblue zemyblue added the ci label Apr 3, 2023
@zemyblue zemyblue changed the title fix: fix release-build ci fix: fix release-build ci error occurred when adding assets after tagging Apr 3, 2023
Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 1c02746 into rc/v1.0.0-rc0 Apr 3, 2023
@zemyblue zemyblue deleted the fix/fix_tag_ci_error branch April 3, 2023 07:13
zemyblue added a commit that referenced this pull request Apr 3, 2023
* rc/v1.0.0-rc0:
  Bump github.com/line/lbm-sdk from v0.47.0-rc2 to v0.47.0-rc3 (#162)
  fix: fix `release-build` ci error occurred when adding assets after tagging (#163)

Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	go.mod
#	go.sum
zemyblue added a commit to zemyblue/finschia that referenced this pull request Apr 21, 2023
* rc/v1.0.0-rc0: (26 commits)
  ci: add a ci to build darwin version when add tag (Finschia#180)
  chore: Release v1.0.0-rc7 (Finschia#179)
  Bump github.com/Finschia/finschia-sdk from v0.47.0-rc6 to v0.47.0-rc7 (Finschia#178)
  chore: Release v1.0.0-rc6 (Finschia#177)
  build: rename and bump up dependencies (Finschia#176)
  chore: bump up lbm-sdk from v0.47.0-rc5 to v0.47.0-rc5.0.20230414034539-489c442416cd (Finschia#174)
  chore: Release v1.0.0-rc5 (Finschia#173)
  Bump github.com/line/lbm-sdk from v0.47.0-rc4.0.20230410115856-b8421116b3f2 to v0.47.0-rc5 (Finschia#172)
  chore: apply wasmd v0.1.2 (Finschia#171)
  fix license copyright holder and typo (Finschia#170)
  Bump github.com/line/lbm-sdk from v0.47.0-rc4 to v0.47.0-rc4.0.20230410115856-b8421116b3f2 (Finschia#168)
  Bump up github.com/line/lbm-sdk from v0.47.0-rc3 to v0.47.0-rc4 (Finschia#167)
  chore: release v1.0.0-rc3 (Finschia#166)
  feat: bump up ibc-go v3.3.2 and wasmd for changing ibc light client of Ostracon to Tendermint (Finschia#164)
  chore: update license notice and code_of_conduct (Finschia#165)
  Bump github.com/line/lbm-sdk from v0.47.0-rc2 to v0.47.0-rc3 (Finschia#162)
  fix: fix `release-build` ci error occurred when adding assets after tagging (Finschia#163)
  chore: release v1.0.0-rc2 (Finschia#160)
  Bump github.com/line/lbm-sdk from v0.47.0-rc1 to v0.47.0-rc2 (Finschia#159)
  chore: update build args to arm64 (Finschia#157)
  ...
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants