Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add filtering function in StargateMsg of wasm #352

Merged
merged 9 commits into from
May 8, 2024
Merged

feat!: add filtering function in StargateMsg of wasm #352

merged 9 commits into from
May 8, 2024

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 3, 2024 •
edited
Loading

Description

Add filtering function in StargateMsg of wasm
Current deny list is lbm.fswap.v1.* and lbm.fbridge.v1.*.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@zemyblue
feat: add filtering function in StargateMsg of wasm
87017b8 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue self-assigned this May 3, 2024
@zemyblue zemyblue changed the title feat: add filtering function in StargateMsg of wasm feat!: add filtering function in StargateMsg of wasm May 3, 2024
@zemyblue
chore: update changelog
2adbcc1 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: lint errors
6747bd2 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: check-format warning
6747ffc 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue mentioned this pull request May 3, 2024
Closed
5 tasks
tkxkd0159
tkxkd0159 reviewed May 8, 2024
View reviewed changes
app/wasm_filter.go Outdated Show resolved Hide resolved
app/wasm_filter_test.go Show resolved Hide resolved
@zemyblue
chore: change deniedModulesInStargateMsg location.
54ace4d 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested a review from tkxkd0159 May 8, 2024 03:19
@zemyblue
chore: remove unnecessary encoder unittests.
2c147bc 
Signed-off-by: zemyblue <zemyblue@gmail.com>
loloicci
loloicci reviewed May 8, 2024
View reviewed changes
app/wasm_filter.go Outdated Show resolved Hide resolved
app/wasm_filter.go Outdated Show resolved Hide resolved
@zemyblue
chore: change error message.
0a92b50 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested a review from loloicci May 8, 2024 04:22
da1suk8
da1suk8 previously approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@da1suk8 da1suk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeseung-bae
jaeseung-bae previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mdaiki0730
Copy link
Member

Would you add a comment or test pattern explaining why CustomMsg should not be checked?
https://github.com/Finschia/wasmvm/blob/v1.1.1-0.12.0/types/msg.go#L101

@zemyblue
chore: change error message.
98370b3 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue dismissed stale reviews from jaeseung-bae and da1suk8 via 98370b3 May 8, 2024 05:41
@zemyblue
chore: add CustomMsg test
f3e75ae 
Signed-off-by: zemyblue <zemyblue@gmail.com>
Mdaiki0730
Mdaiki0730 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@Mdaiki0730 Mdaiki0730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit b7df20b into Finschia:main May 8, 2024
41 checks passed
@zemyblue zemyblue deleted the feature/wasm_filtering branch May 8, 2024 06:05
@zemyblue zemyblue mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@Mdaiki0730 Mdaiki0730 Mdaiki0730 approved these changes

@loloicci loloicci loloicci approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

@da1suk8 da1suk8 Awaiting requested review from da1suk8

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zemyblue @Mdaiki0730 @loloicci @tkxkd0159 @da1suk8 @jaeseung-bae