Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: replace deprecated linters with new ones #361

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented May 9, 2024

Description

closes: #XXXX

  • maligned -> govet
  • varcheck, structcheck, deadcode -> unused
  • golint -> revive
  • scopelint -> exportloopref

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@tkxkd0159 tkxkd0159 added the ci label May 9, 2024
@tkxkd0159 tkxkd0159 self-assigned this May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.45%. Comparing base (281b1e1) to head (b883142).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   50.28%   52.45%   +2.16%     
==========================================
  Files          10       10              
  Lines        1406     1102     -304     
==========================================
- Hits          707      578     -129     
+ Misses        654      479     -175     
  Partials       45       45              

see 8 files with indirect coverage changes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tkxkd0159 tkxkd0159 merged commit bfdd0ab into main May 9, 2024
45 checks passed
@tkxkd0159 tkxkd0159 deleted the update-linter branch May 9, 2024 13:46
mergify bot pushed a commit that referenced this pull request May 9, 2024

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
(cherry picked from commit bfdd0ab)
tkxkd0159 added a commit that referenced this pull request May 10, 2024

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
(cherry picked from commit bfdd0ab)

Co-authored-by: Jaeseung Lee <41176085+tkxkd0159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants