Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

fix: fix to check the negative cache size #11

Merged
merged 2 commits into from
Feb 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const (

// Metrics contains metrics exposed by this package.
type Metrics struct {
NodeCacheSize metrics.Gauge
NodeCacheHits metrics.Counter
NodeCacheMisses metrics.Counter
}
Expand All @@ -28,6 +29,12 @@ func PrometheusMetrics(namespace string, storeName string, labelsAndValues ...st
labels = append(labels, labelsAndValues[i])
}
return &Metrics{
NodeCacheSize: prometheus.NewGaugeFrom(stdprometheus.GaugeOpts{
Namespace: namespace,
Subsystem: MetricsSubsystem,
Name: storeName + "_node_cache_size",
Help: "The maximum number of entries in the iavl node db cache",
}, labels).With(labelsAndValues...),
NodeCacheHits: prometheus.NewCounterFrom(stdprometheus.CounterOpts{
Namespace: namespace,
Subsystem: MetricsSubsystem,
Expand All @@ -46,6 +53,7 @@ func PrometheusMetrics(namespace string, storeName string, labelsAndValues ...st
// NopMetrics returns no-op Metrics.
func NopMetrics() *Metrics {
return &Metrics{
NodeCacheSize: discard.NewGauge(),
NodeCacheHits: discard.NewCounter(),
NodeCacheMisses: discard.NewCounter(),
}
Expand Down
4 changes: 4 additions & 0 deletions nodedb.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ func newNodeDB(db dbm.DB, cacheSize int, opts *Options) *nodeDB {
if opts.Metrics == nil {
opts.Metrics = NopMetrics()
}
if cacheSize < 0 {
cacheSize = 0
}
opts.Metrics.NodeCacheSize.Set(float64(cacheSize))
return &nodeDB{
db: db,
batch: db.NewBatch(),
Expand Down