chore: remove abci socket implementation #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://github.com/line/lbm/issues/1305
Cherry-pick: #153
Description
We aim to optimize the chain performance. One of strateges is increasing concurrency. For it, we need to revise abci interface. Currently, the biggest challenge is to remove
flush()
api from abci interface. This api is meaningful only for socket implementation. We do not use grpc/socket abci implementation at this moment and do not have any plan to use it. So I tried to remove socket implementation. It makes us more flexible to optimize performance.Now
abci-cli
only supportsgrpc
but notsocket
. All tests, usingsocket
previously, are now revised to usegrpc
. So all tests are sill valid and should be passed.Dropped first approach
I tried to remove abci grpc and socket implementations together. But I get realized that we need at least one remote abci implementation for tests. Removing all remote abci implementation makes test harder. And also I get realized that it's only need to remove
socket
implementation in order to removeflush()
api.ABCI implementations
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer