Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove panic for unexpected tx response in resCbRecheck #394

Merged
merged 2 commits into from
Apr 7, 2022
Merged

fix: Remove panic for unexpected tx response in resCbRecheck #394

merged 2 commits into from
Apr 7, 2022

Conversation

Kynea0b
Copy link
Contributor

@Kynea0b Kynea0b commented Apr 6, 2022

Description

Remove panic for unexpected tx response in resCbRecheck. See this issue #395 for details.

@Kynea0b Kynea0b requested review from torao and tnasu as code owners April 6, 2022 07:29
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #394 (c09d040) into main (6069aff) will increase coverage by 0.03%.
The diff coverage is 67.63%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   65.15%   65.18%   +0.03%     
==========================================
  Files         278      277       -1     
  Lines       37743    37832      +89     
==========================================
+ Hits        24590    24662      +72     
+ Misses      11370    11368       -2     
- Partials     1783     1802      +19     
Impacted Files Coverage Δ
cmd/ostracon/commands/reset_priv_validator.go 37.86% <31.57%> (+26.32%) ⬆️
mempool/clist_mempool.go 83.09% <58.33%> (-0.73%) ⬇️
crypto/secp256k1/secp256k1.go 69.56% <75.67%> (+2.89%) ⬆️
consensus/state.go 73.38% <93.18%> (+0.16%) ⬆️
consensus/reactor.go 75.02% <100.00%> (+2.27%) ⬆️
blockchain/v0/pool.go 78.55% <0.00%> (-1.04%) ⬇️
abci/client/socket_client.go 72.09% <0.00%> (-0.88%) ⬇️
p2p/pex/pex_reactor.go 79.67% <0.00%> (-0.62%) ⬇️
light/client.go 61.61% <0.00%> (-0.45%) ⬇️
... and 4 more

@torao torao added the C: bug Classification: Something isn't working label Apr 6, 2022
mempool/clist_mempool.go Outdated Show resolved Hide resolved
mempool/clist_mempool.go Show resolved Hide resolved
Copy link
Member

@tnasu tnasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to change Closes #xxx in the overview? Because I think this PR cannot fix it completely.

@Kynea0b
Copy link
Contributor Author

Kynea0b commented Apr 7, 2022

@tnasu Yes. I will do so. Certainly only a part of the issue has been modified, so close is deleted.

Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants