Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main patch tm-v0.34.18, v0.34.19 #401

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Main patch tm-v0.34.18, v0.34.19 #401

merged 4 commits into from
Apr 15, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Apr 13, 2022 •
edited
Loading

Description

v0.34.18

STATUS: commit hash

Description

v0.34.19

STATUS: commit hash

tnasu and others added 3 commits April 13, 2022 15:41
@tnasu @cmwaters
cli: fix reset command for v0.34 (#8258)
b4e7b30 
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@tnasu @alexanderbez
cli: fix reset commands #8270
3ac561c 
Some applications use the command-line implementations directly,
rather than through the root command. Because the implentations
obtained config from an unexported global, this would not work.

Instead, have each command that needs the config parse it where
needed.

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@tnasu
Fix lint: cli: fix reset commands #8270
4f858e1
@codecov
Copy link

codecov bot commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #401 (4c856a3) into main (9615276) will increase coverage by 0.28%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   65.16%   65.44%   +0.28%     
==========================================
  Files         277      277              
  Lines       37832    37868      +36     
==========================================
+ Hits        24653    24784     +131     
+ Misses      11373    11273     -100     
- Partials     1806     1811       +5
Impacted Files Coverage Δ
privval/file.go 74.90% <0.00%> (-0.10%) ⬇️
cmd/ostracon/commands/reset.go 50.44% <80.00%> (ø)
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
crypto/ed25519/ed25519.go 45.12% <0.00%> (-1.22%) ⬇️
mempool/reactor.go 78.57% <0.00%> (-1.10%) ⬇️
mempool/clist_mempool.go 82.26% <0.00%> (-0.83%) ⬇️
light/client.go 61.61% <0.00%> (-0.45%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
crypto/vrf/vrf_r2ishiguro.go
crypto/vrf/vrf_libsodium.go 78.57% <0.00%> (ø)
... and 13 more

@tnasu tnasu self-assigned this Apr 13, 2022
@tnasu tnasu marked this pull request as ready for review April 14, 2022 04:48
@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Apr 15, 2022
Kynea0b
Kynea0b approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnasu tnasu merged commit d88bf70 into Finschia:main Apr 15, 2022
@tnasu tnasu deleted the main-patch-tm-v0.34.19 branch April 28, 2022 08:02
@tnasu tnasu mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b