Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PubKey/PrivKey prefixes of "ostracon/" to "tendermint/" for compatibility (#445) #447

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

torao
Copy link
Contributor

@torao torao commented Jul 26, 2022

Description

This PR changes the name of public and private key prefixes ostracon/ to tendermint/ for compatibility with Cosmos assets.

  1. The private key may remain "ostracon/PrivKeyXxx" since it's never exposed to the outside world. However, it makes no sense to keep the ostracon prefix until the key pair names are asymmetric, so it's modified with "tendermint/PrivKeyXxx"
  2. BLS12 and Composite key types are not compatible rather than current Cosmos assets to begin with. To make this clear, these Ostracon-specific prefixes are left as "ostracon/". If the Cosmos assets will support the Ostracon specification, they would adopt the ostracon/ prefix :)

Closes: #445

…a#445)

1. The private key may remain "pstracon/PrivKeyXxx" as it's never exposed to outside world. However, it makes no sense to keep the ostracon prefix even with asymmetric naming, so it should be modified with "tendermint/PrivKeyXxx"
2. BLS12 and Composite key types are not compatible with current Cosmos assets to begin with.  To make this clear, these Ostracon-specific prefixes are left as "ostracon/".
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jul 26, 2022
@torao torao self-assigned this Jul 26, 2022
@torao torao requested review from Kynea0b and tnasu as code owners July 26, 2022 05:38
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #447 (4eb4729) into main (f42887f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   65.48%   65.51%   +0.03%     
==========================================
  Files         278      278              
  Lines       37926    37926              
==========================================
+ Hits        24834    24847      +13     
+ Misses      11284    11270      -14     
- Partials     1808     1809       +1     
Impacted Files Coverage Δ
config/toml.go 74.19% <ø> (ø)
crypto/ed25519/ed25519.go 46.34% <ø> (ø)
crypto/secp256k1/secp256k1.go 69.56% <ø> (ø)
crypto/sr25519/encoding.go 100.00% <ø> (ø)
privval/signer_server.go 89.28% <0.00%> (-5.36%) ⬇️
statesync/snapshots.go 93.71% <0.00%> (-1.26%) ⬇️
consensus/reactor.go 74.57% <0.00%> (-0.98%) ⬇️
p2p/pex/pex_reactor.go 80.28% <0.00%> (-0.62%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
consensus/state.go 73.85% <0.00%> (+0.11%) ⬆️
... and 5 more

@tnasu tnasu requested a review from zemyblue July 26, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change pubkey/privatekey type name from ostracon to tendermint
3 participants