-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zerolog based rolling log system #535
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 66.03% 66.14% +0.11%
==========================================
Files 279 280 +1
Lines 38045 38119 +74
==========================================
+ Hits 25122 25213 +91
+ Misses 11123 11107 -16
+ Partials 1800 1799 -1
|
Thanks for the PR. e2e and r2ishiguro require several tests to succeed, so please retry. @dudong2 |
After 7 retries, it passed. The e2e-test has a very frequent failure rate. There were no cases of failure on my local. Do you know why there are so many failures? If it is opened to external developers in the future, is there any plan to revise this test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR reduced the failure rate. Thanks |
Description
Currently, log level setting by module and rotation log system are not available in lbm-sdk's log system. In order to support these functions, a zerolog-based extended log system is implemented.
Closes: #825