Replace unqualified emojis with fully qualified counterparts #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The picker is currently using unqualified and minimally-qualified Unicode sequences for some emojis, which may cause rendering issues on certain browsers and devices. This commit replaces all of the unqualified emojis with their fully qualified counterparts based on the list of emojis published by unicode.org. - https://www.unicode.org/Public/emoji/15.1/emoji-test.txt FIXED=Fintasys#173 BUG=Fintasys#163
|
I didn't know that's even a thing. Thanks for pointing that out and provide updates for all affected emojis! This alone unfortunately didn't fix the biggest display errors we face in some emoji, but I will also check your other PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The picker is currently using unqualified and minimally-qualified Unicode sequences for some emojis, which may cause rendering issues on certain browsers and devices. This commit replaces all of the unqualified emojis with their fully qualified counterparts based on the list of emojis published by unicode.org.
FIXED=#173
BUG=#163